tomcat-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matthias Hryniszak <pad...@gmail.com>
Subject Re: Maven Tomcat 6/7/8 plugin
Date Tue, 07 Oct 2014 19:56:56 GMT
Daniel,

unfortunately after careful examination it turns out that there is a
difference in how the RemoteIpFilter and RemoteIpValve work.

The filter operates on a wrapped request. This means that the call to
request.getRequestURL() - as used by
org.apache.cxf.transport.http.AbstractHTTPDestination.setupMessage(...) -
since it is not overwritten it is invoked directly on the original
org.apache.catalina.connector.Request (through
org.apache.catalina.connector.RequestFacade) and not on the wrapper. The
latter one doesn't know about the modifications to request properties as
they are implemented in another instance.

The valve modifies directly the underlying
org.apache.catalina.connector.Request and therefore the call to
Request.getRequestURL() returns the actual result.

So I guess we're back to square one where a solution to add the
RequestIpValve is the only viable solution (not just in this case but
basically everywhere where the Request.getRequestURL() method is used since
it does not return proper result).

Any ideas on getting the valve installed when running mvn tomcat7:run in
the current version (2.2) ?

Thanks in advance!


Best regards,
Matthias.

2014-10-06 13:45 GMT+02:00 Matthias Hryniszak <padcom@gmail.com>:

> Perfect! I didn't know about this one. Thanks!
>
> 2014-10-06 13:37 GMT+02:00 Daniel Mikusa <dmikusa@pivotal.io>:
>
>>  On Sun, Oct 5, 2014 at 2:00 PM, Matthias Hryniszak <padcom@gmail.com>
>> wrote:
>>
>>> It seems I might have expressed myself purely. Let me rephrase:
>>>
>>> I'm looking for RemoteIpValve support in maven-tomcat7-plugin.
>>
>>
>> Perhaps you could use RemoteIPFilter instead?  You can configure that
>> through web.xml.
>>
>>
>> http://tomcat.apache.org/tomcat-7.0-doc/config/filter.html#Remote_IP_Filter
>>
>> Dan
>>
>>
>>> I know the
>>> valve itself exists since long before version 7 and I am already using it
>>> in production. What I'm on to here is running Maven-managed web
>>> applications in development and as far as I can see it's been added ~2
>>> weeks after the release of 2.2 version of that plugin
>>>
>>> Alternatively if you know of a way to persuade Apache CXF to present the
>>> endpoint URL using HTTPS scheme when running mvn tomcat7:run. CXF does it
>>> automatically if the RemoteIpValve  is installed and proper header exists
>>> (as in the isSecure() method returns true). Otherwise it does just HTTP
>>> and
>>> that in turn makes my local HAProxy do a 302 to HTTPS which ends up in an
>>> infinite loop and that's not exactly the result I was hoping for...
>>>
>>> Cheers,
>>> Matthias
>>>
>>> 2014-10-05 19:31 GMT+02:00 Konstantin Kolinko <knst.kolinko@gmail.com>:
>>>
>>> > 2014-10-05 18:01 GMT+04:00 Matthias Hryniszak <padcom@gmail.com>:
>>> > > Hi all,
>>> > >
>>> > > I'm new to this list so let me briefly introduce myself. My name is
>>> > > Matthias and I live in Poland. I'm a software architect for Lumesse,
>>> an
>>> > > British software development company. The core of our development is
>>> > talent
>>> > > acquisition and talent management software. The part I'm working
>>> with is
>>> > > e-learning solutions.
>>> > >
>>> > > Now that you all know me let me ask you a question: are there any
>>> plans
>>> > on
>>> > > releasing a new version of the maven-tomcat7-plugin and/or an
>>> upgrade to
>>> > > maven-tomcat8-plugin? We're falling short a bit on the lack of
>>> remote IP
>>> > > valve in the current release
>>> >
>>> > RemoteIpValve does exist in Tomcat 7
>>> >
>>> http://tomcat.apache.org/tomcat-7.0-doc/config/valve.html#Remote_IP_Valve
>>> >
>>> > > and I was wondering if that's going to be
>>> > > released any time soon. Please note the last release (2.2) was
>>> November
>>> > > 2013 and there's been lots of changes so it'd be great to have them
>>> > > stabilized and released - not to mention the upgrade over embedded
>>> Tomcat
>>> > > version.
>>> >
>>> > It is being developed on a branch,
>>> > http://svn.apache.org/viewvc/tomcat/maven-plugin/branches/tc8.x/
>>> >
>>> > See archives of tomcat dev mailing list for discussions.
>>> >
>>> > Thus far, integration tests are failing,
>>> > http://markmail.org/message/xc5r6yycrvmjh2vx
>>> >
>>> >
>>> > Best regards,
>>> > Konstantin Kolinko
>>> >
>>> > ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
>>> > For additional commands, e-mail: users-help@tomcat.apache.org
>>> >
>>> >
>>>
>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message