Mailing-List: contact users-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Users List" <users@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: domain of nicholas@nicholaswilliams.net
 designates 209.85.161.173 as permitted sender)
From: Nick Williams <nicholas@nicholaswilliams.net>
Mime-Version: 1.0 (Apple Message framework v1283)
Content-Type: multipart/signed;
 boundary="Apple-Mail=_6E9E837C-25E2-4EB7-BF67-35ED73B62D53";
 protocol="application/pkcs7-signature"; micalg=sha1
Subject: Re: Print parameters in Tomcat JDBC Pool's SlowQueryReport
Date: Wed, 8 May 2013 12:34:23 -0500
In-Reply-To: <518A8697.9000801@gmx.net>
To: "Tomcat Users List" <users@tomcat.apache.org>
References: 
 <trinity-67d26e18-a113-4e40-bfe2-563f00afdc9a-1367996508750@3capp-gmx-bs26>
 <518A3CDE.6080809@christopherschultz.net>
 <ECE59877-3960-4A35-8F17-293CFA8C3A66@nicholaswilliams.net>
 <518A475B.7040803@christopherschultz.net> <518A8697.9000801@gmx.net>
Message-Id: <7EA27350-E437-43B9-A9C8-233D996C60AA@nicholaswilliams.net>

--Apple-Mail=_6E9E837C-25E2-4EB7-BF67-35ED73B62D53
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii


On May 8, 2013, at 12:08 PM, Michael-O wrote:

> Am 2013-05-08 14:38, schrieb Christopher Schultz:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA256
>>=20
>> Nick,
>>=20
>> On 5/8/13 8:08 AM, Nick Williams wrote:
>>>=20
>>> On May 8, 2013, at 6:54 AM, Christopher Schultz wrote:
>>>=20
>>>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
>>>>=20
>>>> Michael,
>>>>=20
>>>> On 5/8/13 3:01 AM, Michael-O wrote:
>>>>> I recently have started using the SlowQueryReport to tackle
>>>>> performance issues. The log message, unfortunately, does not
>>>>> contain the parameters passed to the prepared statements.
>>>>> Though AbstractQueryReport receives this information in
>>>>>=20
>>>>> protected String report*Query(String query, Object[] args,
>>>>> final String name, long start, long delta)
>>>>>=20
>>>>> but ignores this information. The report would highly benefit
>>>>> from. E.g., Commons DBUtils prints out the query and the
>>>>> parameters in the case of an exception. The sole query isn't
>>>>> really helpful.
>>>>>=20
>>>>> Can we add this?
>>>>=20
>>>> Sure.
>>>>=20
>>>>> Should I file a ticket?
>>>>=20
>>>> Yes. A BZ issue with a patch is likely to get done a whole lot
>>>> faster than one without a patch (plus you get credit for your
>>>> contribution).
>>>>=20
>>>> - -chris
>>>=20
>>> There needs to be an option to disable logging query parameters
>>> somehow. Query parameters are sometimes sensitive, and in some
>>> environments (medical, legal, etc.) logging them might even be in
>>> violation of the law.
>>=20
>> +1
>>=20
>> If you really want to get cute, allow the user to specify named query
>> parameters that should never be displayed "e.g. 'password'", though
>> this is a) perhaps not possible and b) not reliable because you can
>> bind parameters by position as well as by name.
>=20
> Java has no support for named parameters. How is that supposed to =
work?

Agreed that it the setting won't be effective if they don't use prepared =
statements. Therefore, the setting name should reflect this restriction.

I'm not sure what Chris is referring to. You are right, Java has no =
support for named parameters, even in Java 8. Chris might be thinking of =
Hibernate or Spring's JdbcTemplate, which permit using named parameters. =
Ultimately, these get converted to indexed parameters before the query =
is actually executed.

Nick=

--Apple-Mail=_6E9E837C-25E2-4EB7-BF67-35ED73B62D53
Content-Disposition: attachment;
	filename=smime.p7s
Content-Type: application/pkcs7-signature;
	name=smime.p7s
Content-Transfer-Encoding: base64

MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIMnDCCBjQw
ggQcoAMCAQICAR4wDQYJKoZIhvcNAQEFBQAwfTELMAkGA1UEBhMCSUwxFjAUBgNVBAoTDVN0YXJ0
Q29tIEx0ZC4xKzApBgNVBAsTIlNlY3VyZSBEaWdpdGFsIENlcnRpZmljYXRlIFNpZ25pbmcxKTAn
BgNVBAMTIFN0YXJ0Q29tIENlcnRpZmljYXRpb24gQXV0aG9yaXR5MB4XDTA3MTAyNDIxMDE1NVoX
DTE3MTAyNDIxMDE1NVowgYwxCzAJBgNVBAYTAklMMRYwFAYDVQQKEw1TdGFydENvbSBMdGQuMSsw
KQYDVQQLEyJTZWN1cmUgRGlnaXRhbCBDZXJ0aWZpY2F0ZSBTaWduaW5nMTgwNgYDVQQDEy9TdGFy
dENvbSBDbGFzcyAxIFByaW1hcnkgSW50ZXJtZWRpYXRlIENsaWVudCBDQTCCASIwDQYJKoZIhvcN
AQEBBQADggEPADCCAQoCggEBAMcJg8zOLdgasSmkLhOrlr6KMoOMpohBllVHrdRvEg/q6r8jR+EK
75xCGhR8ToREoqe7zM9/UnC6TS2y9UKTpT1v7RSMzR0t6ndl0TWBuUr/UXBhPk+Kmy7bI4yW4urC
+y7P3/1/X7U8ocb8VpH/Clt+4iq7nirMcNh6qJR+xjOhV+VHzQMALuGYn5KZmc1NbJQYclsGkDxD
z2UbFqE2+6vIZoL+jb9x4Pa5gNf1TwSDkOkikZB1xtB4ZqtXThaABSONdfmv/Z1pua3FYxnCFmdr
/+N2JLKutIxMYqQOJebr/f/h5t95m4JgrM3Y/w7YX9d7YAL9jvN4SydHsU6n65cCAwEAAaOCAa0w
ggGpMA8GA1UdEwEB/wQFMAMBAf8wDgYDVR0PAQH/BAQDAgEGMB0GA1UdDgQWBBRTcu2SnODaywFc
fH6WNU7y1LhRgjAfBgNVHSMEGDAWgBROC+8apEBbpRdphzDKNGhD0EGu8jBmBggrBgEFBQcBAQRa
MFgwJwYIKwYBBQUHMAGGG2h0dHA6Ly9vY3NwLnN0YXJ0c3NsLmNvbS9jYTAtBggrBgEFBQcwAoYh
aHR0cDovL3d3dy5zdGFydHNzbC5jb20vc2ZzY2EuY3J0MFsGA1UdHwRUMFIwJ6AloCOGIWh0dHA6
Ly93d3cuc3RhcnRzc2wuY29tL3Nmc2NhLmNybDAnoCWgI4YhaHR0cDovL2NybC5zdGFydHNzbC5j
b20vc2ZzY2EuY3JsMIGABgNVHSAEeTB3MHUGCysGAQQBgbU3AQIBMGYwLgYIKwYBBQUHAgEWImh0
dHA6Ly93d3cuc3RhcnRzc2wuY29tL3BvbGljeS5wZGYwNAYIKwYBBQUHAgEWKGh0dHA6Ly93d3cu
c3RhcnRzc2wuY29tL2ludGVybWVkaWF0ZS5wZGYwDQYJKoZIhvcNAQEFBQADggIBAAqDCH14qywG
XLhjjF6uHLkjd02hcdh9hrw+VUsv+q1eeQWB21jWj3kJ96AUlPCoEGZ/ynJNScWy6QMVQjbbMXlt
UfO4n4bGGdKo3awPWp61tjAFgraLJgDk+DsSvUD6EowjMTNx25GQgyYJ5RPIzKKR9tQW8gGK+2+R
HxkUCTbYFnL6kl8Ch507rUdPPipJ9CgJFws3kDS3gOS5WFMxcjO5DwKfKSETEPrHh7p5shuuNktv
sv6hxHTLhiMKX893gxdT3XLS9OKmCv87vkINQcNEcIIoFWbP9HORz9v3vQwR4e3ksLc2JZOAFK+s
sS5XMEoznzpihEP0PLc4dCBYjbvSD7kxgDwZ+Aj8Q9PkbvE9sIPP7ON0fz095HdThKjiVJe6vofq
+n6b1NBc8XdrQvBmunwxD5nvtTW4vtN6VY7mUCmxsCieuoBJ9OlqmsVWQvifIYf40dJPZkk9YgGT
zWLpXDSfLSplbY2LL9C9U0ptvjcDjefLTvqSFc7tw1sEhF0n/qpA2r0GpvkLRDmcSwVyPvmjFBGq
Up/pNy8ZuPGQmHwFi2/14+xeSUDG2bwnsYJQG2EdJCB6luQ57GEnTA/yKZSTKI8dDQa8Sd3zfXb1
9mOgSF0bBdXbuKhEpuP9wirslFe6fQ1t5j5R0xi72MZ8ikMu1RQZKCyDbMwazlHiMIIGYDCCBUig
AwIBAgIDBlQ9MA0GCSqGSIb3DQEBBQUAMIGMMQswCQYDVQQGEwJJTDEWMBQGA1UEChMNU3RhcnRD
b20gTHRkLjErMCkGA1UECxMiU2VjdXJlIERpZ2l0YWwgQ2VydGlmaWNhdGUgU2lnbmluZzE4MDYG
A1UEAxMvU3RhcnRDb20gQ2xhc3MgMSBQcmltYXJ5IEludGVybWVkaWF0ZSBDbGllbnQgQ0EwHhcN
MTMwNDA1MTE1NDQ0WhcNMTQwNDA1MTcyMjQ4WjBxMRkwFwYDVQQNExBVbkY2N0NFOGN1c0tWWktu
MSYwJAYDVQQDDB1uaWNob2xhc0BuaWNob2xhc3dpbGxpYW1zLm5ldDEsMCoGCSqGSIb3DQEJARYd
bmljaG9sYXNAbmljaG9sYXN3aWxsaWFtcy5uZXQwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEK
AoIBAQDLgBPwKIwypzdH0PsO4USK4VXoa7TuC7UJcqY+mlx5dhPuiYxQsar8hgw0ndgbDYDLU1Lb
ndsp36avOmqiWQKMFUVjQvCGVCQBMy/wbIEL7i0INOMKf0PlkQkkT7hvTJep7IH9VAvbw/3A5n8E
frUckOjhY97J3BQiaokiwgGqiUumfnRMVpncj13vgt+Xn7zW/nbgmCtj5x4bGPsMAoqhJ8JAdNCO
3jdrSzxzI8gttlRAIWeVnc2vQL3xEmtU3UBuJn4lHMDjtLj1i5GEeqSRwFMRnZWZgERk1ltMC6Ym
fKsGn2Pi31NyrNLvpAqKUegpUbl7MZMop/YJ+rz2VcJ3AgMBAAGjggLjMIIC3zAJBgNVHRMEAjAA
MAsGA1UdDwQEAwIEsDAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwHQYDVR0OBBYEFD8x
Hi5nTwWdMDcZOsznCugpJqL2MB8GA1UdIwQYMBaAFFNy7ZKc4NrLAVx8fpY1TvLUuFGCMCgGA1Ud
EQQhMB+BHW5pY2hvbGFzQG5pY2hvbGFzd2lsbGlhbXMubmV0MIIBTAYDVR0gBIIBQzCCAT8wggE7
BgsrBgEEAYG1NwECAzCCASowLgYIKwYBBQUHAgEWImh0dHA6Ly93d3cuc3RhcnRzc2wuY29tL3Bv
bGljeS5wZGYwgfcGCCsGAQUFBwICMIHqMCcWIFN0YXJ0Q29tIENlcnRpZmljYXRpb24gQXV0aG9y
aXR5MAMCAQEagb5UaGlzIGNlcnRpZmljYXRlIHdhcyBpc3N1ZWQgYWNjb3JkaW5nIHRvIHRoZSBD
bGFzcyAxIFZhbGlkYXRpb24gcmVxdWlyZW1lbnRzIG9mIHRoZSBTdGFydENvbSBDQSBwb2xpY3ks
IHJlbGlhbmNlIG9ubHkgZm9yIHRoZSBpbnRlbmRlZCBwdXJwb3NlIGluIGNvbXBsaWFuY2Ugb2Yg
dGhlIHJlbHlpbmcgcGFydHkgb2JsaWdhdGlvbnMuMDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9j
cmwuc3RhcnRzc2wuY29tL2NydHUxLWNybC5jcmwwgY4GCCsGAQUFBwEBBIGBMH8wOQYIKwYBBQUH
MAGGLWh0dHA6Ly9vY3NwLnN0YXJ0c3NsLmNvbS9zdWIvY2xhc3MxL2NsaWVudC9jYTBCBggrBgEF
BQcwAoY2aHR0cDovL2FpYS5zdGFydHNzbC5jb20vY2VydHMvc3ViLmNsYXNzMS5jbGllbnQuY2Eu
Y3J0MCMGA1UdEgQcMBqGGGh0dHA6Ly93d3cuc3RhcnRzc2wuY29tLzANBgkqhkiG9w0BAQUFAAOC
AQEAqmiL7oyZaZ9rqtRdQcmsGmIS5xgQKx0tfwPyAKU8osobfVTRf5sZX4Qez70A6qsEZogJ+1BD
LiY/BEdJNbtldll4f73Dx2flUx8CEhsjheDZ0VEkS968bIaghKurc09KOgpwO4JIPu4h7fr05EK0
p+8TN5dYHWka3vQ6bCStXjRrpdozJQxuY2y58gINbXsEPeflPzN5PUKG0saFfHrITaSAbzcD9dGJ
fYe0jAonA2QfEaX02gqfAYGDEnRY7xsGzml17zVCRH78FrHADvoW28Whnnk16a54rXwNJGpZLHPb
G/tcZcto4N5W0eH5Y+TgIv4FA1ZuHSVJM4v79UfHhTGCA28wggNrAgEBMIGUMIGMMQswCQYDVQQG
EwJJTDEWMBQGA1UEChMNU3RhcnRDb20gTHRkLjErMCkGA1UECxMiU2VjdXJlIERpZ2l0YWwgQ2Vy
dGlmaWNhdGUgU2lnbmluZzE4MDYGA1UEAxMvU3RhcnRDb20gQ2xhc3MgMSBQcmltYXJ5IEludGVy
bWVkaWF0ZSBDbGllbnQgQ0ECAwZUPTAJBgUrDgMCGgUAoIIBrzAYBgkqhkiG9w0BCQMxCwYJKoZI
hvcNAQcBMBwGCSqGSIb3DQEJBTEPFw0xMzA1MDgxNzM0MjRaMCMGCSqGSIb3DQEJBDEWBBTnCVn/
PTT1wKc0LEwU8SPjjsIEJDCBpQYJKwYBBAGCNxAEMYGXMIGUMIGMMQswCQYDVQQGEwJJTDEWMBQG
A1UEChMNU3RhcnRDb20gTHRkLjErMCkGA1UECxMiU2VjdXJlIERpZ2l0YWwgQ2VydGlmaWNhdGUg
U2lnbmluZzE4MDYGA1UEAxMvU3RhcnRDb20gQ2xhc3MgMSBQcmltYXJ5IEludGVybWVkaWF0ZSBD
bGllbnQgQ0ECAwZUPTCBpwYLKoZIhvcNAQkQAgsxgZeggZQwgYwxCzAJBgNVBAYTAklMMRYwFAYD
VQQKEw1TdGFydENvbSBMdGQuMSswKQYDVQQLEyJTZWN1cmUgRGlnaXRhbCBDZXJ0aWZpY2F0ZSBT
aWduaW5nMTgwNgYDVQQDEy9TdGFydENvbSBDbGFzcyAxIFByaW1hcnkgSW50ZXJtZWRpYXRlIENs
aWVudCBDQQIDBlQ9MA0GCSqGSIb3DQEBAQUABIIBABZNxJONoufYxhV/ly9D4SYeKUtXrxAVEc8p
axAhO//dw05gd3LKdCZIECDNi7bZUTcY3TTHvXNXyPQ+1fN5QKv9sZzRR3TcocaTMzKgNIEOMoJP
FASv9I1Z6UCfVoQnR+nExkY0CY64CE7eYfv10Gk/uZq9BEO14AYet0KxjjI+7C82uUhHgvCF15lE
VC23jWrxCjKiQE4IBuquIKPxGoCvFblpLRhNRmIaA4V+AhXHo97YMOqCE7q5rQiN+1jCqr8d4bYr
iJ3IV+vLcUNLGPETiQkFJzmf6aeG3DGIjhpqhbnkXZ9Xc3cEpYdRk9YNNQPe/tbsF3mzbimbXAwP
31kAAAAAAAA=

--Apple-Mail=_6E9E837C-25E2-4EB7-BF67-35ED73B62D53--