tomcat-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Schultz <ch...@christopherschultz.net>
Subject Re: Print parameters in Tomcat JDBC Pool's SlowQueryReport
Date Wed, 08 May 2013 17:42:06 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Michael,

On 5/8/13 1:14 PM, Michael-O wrote:
> Christopher,
> 
> Am 2013-05-08 13:54, schrieb Christopher Schultz:
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
>> 
>> Michael,
>> 
>> On 5/8/13 3:01 AM, Michael-O wrote:
>>> I recently have started using the SlowQueryReport to tackle 
>>> performance issues. The log message, unfortunately, does not 
>>> contain the parameters passed to the prepared statements.
>>> Though AbstractQueryReport receives this information in
>>> 
>>> protected String report*Query(String query, Object[] args,
>>> final String name, long start, long delta)
>>> 
>>> but ignores this information. The report would highly benefit 
>>> from. E.g., Commons DBUtils prints out the query and the
>>> parameters in the case of an exception. The sole query isn't
>>> really helpful.
>>> 
>>> Can we add this?
>> 
>> Sure.
>> 
>>> Should I file a ticket?
>> 
>> Yes. A BZ issue with a patch is likely to get done a whole lot
>> faster than one without a patch (plus you get credit for your
>> contribution).
> 
> What file should I patch, AbstractQueryReport or QueryReport? I'd 
> exclude JMX for now.

Your choice: whatever seems to make more sense. If a committer reads
and patch and thinks it goes somewhere else, you can re-write it. Or,
you can open the BZ issue, then post to the dev list asking for
suggestions for where to start.

- -chris
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCAAGBQJRio5uAAoJEBzwKT+lPKRYLuwP+wXOVVxKGvPO7GCXZyd/p8bz
g7KZ+wt6cxUpLL/cD2tfBhpFn5rMRHm/40E3P2O62moZOl0cB9ObjL0JaPCGD+Fu
eTf7hqW/ldVsRIOcYaeQZ0hZ0nQXWrQetobcOU1aAZ6tA/OTgzaR1qVZvygzU86H
wEjW9gWQhpnVpjd1M+YrOo4XH48mj1/c2OjHDSMhJhEVgg5qPEmXv5u7hHbdEOyF
ctMx94shFhAhP0PzcJ9Ea71F8zL61cjhbbPr7mVR9SWHCbAol223he6T9nIiuUtO
ABisryyQ8PpN54TCVNHcRhAFXkrkIR6dylhV50FbWJqfjOAhn46L/Q2eHsbeUv4c
hw7RgmE26W4fi86zLPxuvcwLJYDkSe/4dTmBjV7RP6y9UreDcj+5MjuSqcSkQEpl
+B4+R1VnQVv6f3tZ1w9QAB9KbdroHKjDCyb0bnhCSUT6OpKLffU6iz+6N982OVmR
ruOf8+xEIGwbQmj+siFRh6Hb06o6puZOo2O/4ZC3YhEiSoKOkhO48mRzZtAh1mVg
w/X2VQtKZpOGhql3wKU0N+nV3XtO0KB+JGI4V98MTbL9IL4TVtUsd1xgKKoQOc2F
+quRNg1+jRrV718YYjxdATlZLGSsq++GjfLzqZRhoeSlTV4ITwF9NZSKWjFxv0/W
2Zfw/8U+K0B1wBNvvZ+A
=wWhP
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org


Mime
View raw message