tomcat-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Schultz <ch...@christopherschultz.net>
Subject Re: Print parameters in Tomcat JDBC Pool's SlowQueryReport
Date Wed, 08 May 2013 12:38:51 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Nick,

On 5/8/13 8:08 AM, Nick Williams wrote:
> 
> On May 8, 2013, at 6:54 AM, Christopher Schultz wrote:
> 
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
>> 
>> Michael,
>> 
>> On 5/8/13 3:01 AM, Michael-O wrote:
>>> I recently have started using the SlowQueryReport to tackle 
>>> performance issues. The log message, unfortunately, does not 
>>> contain the parameters passed to the prepared statements.
>>> Though AbstractQueryReport receives this information in
>>> 
>>> protected String report*Query(String query, Object[] args,
>>> final String name, long start, long delta)
>>> 
>>> but ignores this information. The report would highly benefit 
>>> from. E.g., Commons DBUtils prints out the query and the
>>> parameters in the case of an exception. The sole query isn't
>>> really helpful.
>>> 
>>> Can we add this?
>> 
>> Sure.
>> 
>>> Should I file a ticket?
>> 
>> Yes. A BZ issue with a patch is likely to get done a whole lot
>> faster than one without a patch (plus you get credit for your
>> contribution).
>> 
>> - -chris
> 
> There needs to be an option to disable logging query parameters 
> somehow. Query parameters are sometimes sensitive, and in some 
> environments (medical, legal, etc.) logging them might even be in 
> violation of the law.

+1

If you really want to get cute, allow the user to specify named query
parameters that should never be displayed "e.g. 'password'", though
this is a) perhaps not possible and b) not reliable because you can
bind parameters by position as well as by name.

- -chris
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCAAGBQJRikdbAAoJEBzwKT+lPKRY78UP/RwHLoAjziifH691fQu5NySU
5TeDj0MMeNGzNy4+4ov6Rclhd48XySKYdyecxsqQERM4FLo/e4R/E6BHdURgNSjA
hcfcRk1t6wGiRLn3wykQxNMBWI7JpWN/oUOcVSnXhi3G7xZKAIJfMqVwO2NkoQw2
GBhjKOD4zGRG17CFWD16jG0akm3LttL4OsjuWiRD5UqkkWkkg9JKJKfe6WRSDLnl
2OYw245UCcC37r79gFHZikvVTlu29mbU80tNj0BEK/PlZjzmnfV5gIZCU3kO7njj
0iT3hTrZ3Y1KOEyptyYEdgHDqVxRf02P3y1brDZmq3au7RiZhBwIMQDHqPB7dXaQ
SDqcUHCrNxgKc/O2ydKX+kgbzLE5cCXGzSWK+UMnjxXqekg/utmss5z48P16UJPh
EAyy5GC4C2M1htpYegFba4o3HvWlu0GnM7W0G+dwzZxrREWwfZCs9ggn4lxd36MS
+rEwBtNsATGalfBy//XGJsXJNgUNuGPsD5bT9Yl1QvNidI8yxa91C1X4sz0wYgXY
3+aA++7hDCb8kvkkGqfJiznD8CQVIsZv7RMzCanlE/3ilBPFslJGnVtC/WggFCJx
HQFqeOPnikRaZMqC0n4XTiM1n2sLuKnI+Fki2j+euPdwa5gDxydE+H4eL5WG/6qe
6mE49gaMqyRXugIeO2W1
=ZISZ
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org


Mime
View raw message