Mailing-List: contact users-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Users List" <users@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: domain of tomasz.kowalczewski@gmail.com
 designates 209.85.220.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <997BA89E-7738-486A-BE76-17A06139B9E6@vmware.com>
References: 
 <CANTKXYmZX6_xKcqnDPJtEf1n18eTOLmc2x0ResjO4pRf1ueM2g@mail.gmail.com>
	<997BA89E-7738-486A-BE76-17A06139B9E6@vmware.com>
Date: Tue, 2 Apr 2013 14:59:56 +0200
Message-ID: 
 <CANTKXYmsKUEc1jhaN4pq9a_PAYJ8h_o4BGhCeOf6mWCHoDq6TA@mail.gmail.com>
Subject: Re: NPE in SlowQuery
From: Tomasz Kowalczewski <tomasz.kowalczewski@gmail.com>
To: Tomcat Users List <users@tomcat.apache.org>
Content-Type: multipart/alternative; boundary=14dae9cdcb876f71db04d96050b3

--14dae9cdcb876f71db04d96050b3
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 2, 2013 at 2:43 PM, Daniel Mikusa <dmikusa@vmware.com> wrote:

> On Apr 2, 2013, at 8:15 AM, Tomasz Kowalczewski wrote:
>
> > Hello all,
> >
> > we are running Tomcat 7 on Amazon EC2:
> >
> > Server version: Apache Tomcat/7.0.22
> > Server built:   Sep 27 2011 09:40:50
> > Server number:  7.0.22.0
>
> As you can see from the date, this version is getting to be pretty old.
>  You should consider upgrading.
>
> > OS Name:        Linux
> > OS Version:     2.6.34.7-56.40.amzn1.i686
> > Architecture:   i386
> > JVM Version:    1.7.0_03-b04
> >
> > And get following exception on slow queries:
> >
> > [catalina-exec-18] 04-02 10:27:11 ERROR TransactionInterceptor:414 -
> > Application exception overridden by rollback exception
> > java.lang.NullPointerException
> >               at
> >
> org.apache.tomcat.jdbc.pool.interceptor.SlowQueryReport.reportFailedQuery=
(SlowQueryReport.java:86)
> >               at
> >
> org.apache.tomcat.jdbc.pool.interceptor.AbstractQueryReport$StatementProx=
y.invoke(AbstractQueryReport.java:237)
> >
> > I wasn't able to google for a solution/bugfix therefore I would like
> > to ask the Tomcat community for help on this issue. Is this a known
> > bug?
>
> There are a couple NPE's reported here.  Could be what you are seeing=85
>
>    https://issues.apache.org/bugzilla/show_bug.cgi?id=3D51582
>
> Probably would be best if you could upgrade to the latest release and see
> if the problem still continues.  If you can't upgrade Tomcat, at least
> upgrade the jdbc-pool jar.
>
> Dan
>
>
> >
> > When looking at the source code:
> >
> > 85:  QueryStats qs =3D this.getQueryStats(sql);
> > 86:  qs.failure(delta, now);
> >
> > It looks like getQueryStats(sql) returned null and indeed it does so
> > on at leas one ocassion:
> >
> >     protected QueryStats getQueryStats(String sql) {
> >          if (sql=3D=3Dnull) sql =3D "";
> >          ConcurrentHashMap<String,QueryStats> queries =3D
> > SlowQueryReport.this.queries;
> >>>       if (queries=3D=3Dnull) return null;
> >
> > However, non of the uses of getQueryStats() in SlowQueryReport guard
> > against this null. It seems to be a bug.
> >
> > --
> > Regards,
> > Tomasz Kowalczewski
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: users-help@tomcat.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: users-help@tomcat.apache.org
>
>

Thanks for your answer. Yes, the tomcat installation is a bit old. I have
checked SlowQueryReport in trunk:

http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/o=
rg/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java?view=3Dlog

and there are only minor changes (generics and toString changes) and no
real fix for getQueryStats returning null. However, I will try upgrading
and will report back if it solves the issue.

--=20
Regards,
Tomasz Kowalczewski

--14dae9cdcb876f71db04d96050b3--