Return-Path: X-Original-To: apmail-tomcat-users-archive@www.apache.org Delivered-To: apmail-tomcat-users-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A5399F2DD for ; Tue, 2 Apr 2013 12:16:08 +0000 (UTC) Received: (qmail 98468 invoked by uid 500); 2 Apr 2013 12:16:05 -0000 Delivered-To: apmail-tomcat-users-archive@tomcat.apache.org Received: (qmail 98318 invoked by uid 500); 2 Apr 2013 12:16:01 -0000 Mailing-List: contact users-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Users List" Delivered-To: mailing list users@tomcat.apache.org Received: (qmail 98278 invoked by uid 99); 2 Apr 2013 12:15:59 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Apr 2013 12:15:59 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of tomasz.kowalczewski@gmail.com designates 209.85.220.169 as permitted sender) Received: from [209.85.220.169] (HELO mail-vc0-f169.google.com) (209.85.220.169) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Apr 2013 12:15:53 +0000 Received: by mail-vc0-f169.google.com with SMTP id kw10so335176vcb.0 for ; Tue, 02 Apr 2013 05:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to :content-type; bh=nefGFetzV+1Rg1XKtotJtFpaukddrnr8UsdPzdccVck=; b=nwle2k2ddya0jjCPAbAQjcrz2D5Oy9+ZUwtxbimfGinMo3zttQUnXlzl2XWMgavquT 4BTJCBP7RIxTuikIfxjec3hIvAAVYrWjwiI7sGEVrNTTFnL2DquYyCfae3D53btoALCA shDyaZmxx26673X0ZDNGBE2Ceebtwsvyg3QpE0MTmwWqAJEDqG9WUQyVHob886vvAo0r LzTW8rCPVvBA6MfUYwRi1rZmiFhQf4y3OhvHzaAcKD2thsbMTXuh/3iBjefv4bzkCJH2 e/X+lGCpXJQRoNPZHwmkvqQfLrX0kigHtBVWiRb+vyc9WiVzc84/4RxLEGPsPtZ4KVRy d5Ew== MIME-Version: 1.0 X-Received: by 10.52.69.49 with SMTP id b17mr10263017vdu.130.1364904932412; Tue, 02 Apr 2013 05:15:32 -0700 (PDT) Received: by 10.58.39.232 with HTTP; Tue, 2 Apr 2013 05:15:32 -0700 (PDT) Date: Tue, 2 Apr 2013 14:15:32 +0200 Message-ID: Subject: NPE in SlowQuery From: Tomasz Kowalczewski To: users@tomcat.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org Hello all, we are running Tomcat 7 on Amazon EC2: Server version: Apache Tomcat/7.0.22 Server built: Sep 27 2011 09:40:50 Server number: 7.0.22.0 OS Name: Linux OS Version: 2.6.34.7-56.40.amzn1.i686 Architecture: i386 JVM Version: 1.7.0_03-b04 And get following exception on slow queries: [catalina-exec-18] 04-02 10:27:11 ERROR TransactionInterceptor:414 - Application exception overridden by rollback exception java.lang.NullPointerException at org.apache.tomcat.jdbc.pool.interceptor.SlowQueryReport.reportFailedQuery(SlowQueryReport.java:86) at org.apache.tomcat.jdbc.pool.interceptor.AbstractQueryReport$StatementProxy.invoke(AbstractQueryReport.java:237) I wasn't able to google for a solution/bugfix therefore I would like to ask the Tomcat community for help on this issue. Is this a known bug? When looking at the source code: 85: QueryStats qs = this.getQueryStats(sql); 86: qs.failure(delta, now); It looks like getQueryStats(sql) returned null and indeed it does so on at leas one ocassion: protected QueryStats getQueryStats(String sql) { if (sql==null) sql = ""; ConcurrentHashMap queries = SlowQueryReport.this.queries; >> if (queries==null) return null; However, non of the uses of getQueryStats() in SlowQueryReport guard against this null. It seems to be a bug. -- Regards, Tomasz Kowalczewski --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org For additional commands, e-mail: users-help@tomcat.apache.org