tomcat-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Schultz <ch...@christopherschultz.net>
Subject Re: Comma related bug in org.apache.catalina.valves.RemoteIpValve
Date Wed, 07 Nov 2012 15:53:24 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Simon,

On 11/7/12 8:14 AM, Simon Dean wrote:
> Thanks for the patched Java Documentation I see you've added to
> the bug report!  Is there a way for me to raise a patch for 
> http://tomcat.apache.org/tomcat-6.0-doc/config/valve.html#Remote_IP_Valve

My
> 
patch does indeed include modifications to the valve.html. If you'd
like to offer a different patch (whether you use mine as a basis or
not), please feel free to do so.

Just download the Tomcat source (I used Tomcat 6.0.x trunk which you
can get from svn, or you can use the latest release version if you'd
like to just download a tarball or zip), apply my patch to it (or
not), then make whatever changes you'd like.

You will then have to take a diff of your changes relative to the
original (which is why svn is so much easier, here, as it can do the
diff for you), save that to a file and upload it as an attachment to
the bug.

If you need more detailed instructions just ask and I'll provide them.

Thanks,
- -chris
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iEYEARECAAYFAlCag/QACgkQ9CaO5/Lv0PCPmACgsws2+gXS/l+rFY2H9eGUumEc
RHQAnR/yq0APeYBXT9JRr4Ys+zuIaxo0
=W9Pc
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org


Mime
View raw message