Mailing-List: contact users-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Users List" <users@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: local policy)
Date: Wed, 8 Aug 2012 05:19:24 -0700 (PDT)
From: Daniel Mikusa <dmikusa@vmware.com>
To: Tomcat Users List <users@tomcat.apache.org>
Message-ID: <22519108.50.1344428364267.JavaMail.daniel@cleveland>
In-Reply-To: 
 <CAEU17ozOrd8cTnmU1zugZ8uTY0fOHLBbLC+S2gph2qJsAmQRDw@mail.gmail.com>
Subject: Re: tomcat-jdbc: correct way to create a new separated
 org.apache.tomcat.jdbc.pool.DataSource from another one
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

----- Original Message -----
> Hello.
>=20
> I have an use case in which I would want to copy an
> `org.apache.tomcat.jdbc.pool.DataSource`, to have two disjoint
> connection
> pools, with some pool properties changed.
>=20
> My first thought was to do something like this:
>=20
> PoolProperties props =3D new
> PoolProperties(baseDataSource.getPoolProperties());
> // set custom props ...
> DataSource newDataSource =3D new DataSource(props);
>=20
>=20
> The problem is that the PoolProperties class doesn't have such
> constructor.
> Another option could be to share the PoolProperties object, but, for
> what
> I've looked into the code, it doesn't seem safe.
>=20
> The PoolProperties class implements the Cloneable interface, so I
> guess
> it's ok to use its clone method. The problem I have with this option
> is
> that DataSource#getPoolProperties() returns a PoolConfiguration which
> doesn't implements Cloneable. In my case I think it would be safe to
> cast
> the PoolConfiguration to PoolProperties, but it doesn't seem safe for
> the
> general case.
>=20
> What would be the correct way to create a new separated DataSource
> from
> another one having some properties changed?
>=20
> I'm using tomcat-jdbc 7.0.29 as a standalone library.
>=20
> Thank you.
>=20
> Regards,
> Germ=C3=A1n
>=20

Have you looked at the method "parsePoolProperties" on the DataSourceFactor=
y class?

  public static PoolConfiguration parsePoolProperties(Properties properties=
)

You could load your configuration into a Properties object, create you firs=
t pool configuration with "parsePoolProperties", alter the Properties objec=
t and then call "parsePoolProperties" on the modified Properties object to =
create your second pool configuration.

Dan


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org