tomcat-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Germán Ferrari <german.ferr...@gmail.com>
Subject tomcat-jdbc: correct way to create a new separated org.apache.tomcat.jdbc.pool.DataSource from another one
Date Tue, 07 Aug 2012 23:06:53 GMT
Hello.

I have an use case in which I would want to copy an
`org.apache.tomcat.jdbc.pool.DataSource`, to have two disjoint connection
pools, with some pool properties changed.

My first thought was to do something like this:

PoolProperties props = new
PoolProperties(baseDataSource.getPoolProperties());
// set custom props ...
DataSource newDataSource = new DataSource(props);


The problem is that the PoolProperties class doesn't have such constructor.
Another option could be to share the PoolProperties object, but, for what
I've looked into the code, it doesn't seem safe.

The PoolProperties class implements the Cloneable interface, so I guess
it's ok to use its clone method. The problem I have with this option is
that DataSource#getPoolProperties() returns a PoolConfiguration which
doesn't implements Cloneable. In my case I think it would be safe to cast
the PoolConfiguration to PoolProperties, but it doesn't seem safe for the
general case.

What would be the correct way to create a new separated DataSource from
another one having some properties changed?

I'm using tomcat-jdbc 7.0.29 as a standalone library.

Thank you.

Regards,
Germán

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message