Mailing-List: contact users-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Users List" <users@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: domain of knst.kolinko@gmail.com
 designates 209.85.160.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <6368FCCCD803D64BB0931D7F5F0A3DD50227830AB1@DEMCHP99E84MSX.ww902.siemens.net>
References: 
 <6368FCCCD803D64BB0931D7F5F0A3DD50227830AB1@DEMCHP99E84MSX.ww902.siemens.net>
Date: Thu, 12 Apr 2012 17:25:16 +0400
Message-ID: 
 <CABzHfV=4zXYQaYehW96emvsN7w6_mOkDXArZTPegX66Pwx-7sA@mail.gmail.com>
Subject: Re: StandardHostValve kills custom error message
From: Konstantin Kolinko <knst.kolinko@gmail.com>
To: Tomcat Users List <users@tomcat.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

2012/4/12 Osipov, Michael <michael.osipov@siemens.com>:
> Hi folks,
>
> I am sending a custom error message in my authenticator but it gets remov=
ed by the StandardHostValve.
> This is what I do in my authenticator:
>
> catch (PrivilegedActionException e) {
> =A0 logger.error("Unable to login as the service principal", e.getExcepti=
on());
>
> =A0 response.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR,
> =A0 =A0 "Unable to login as the service principal");
> =A0 request.setAttribute(Globals.EXCEPTION_ATTR, e);

What happens if you switch the order of the above two lines?

IMHO it is odd to do something after sendError(), sendRedirect() or
RequestDispatcher.forward().

> =A0 return false;
> }
>
> The message is not diplayed because in line 282 to 286 the message is kil=
led by:
> else {
> =A0 =A0 =A0 =A0 =A0 =A0// A custom error-page has not been defined for th=
e exception
> =A0 =A0 =A0 =A0 =A0 =A0// that was thrown during request processing. Chec=
k if an
> =A0 =A0 =A0 =A0 =A0 =A0// error-page for error code 500 was specified and=
 if so,
> =A0 =A0 =A0 =A0 =A0 =A0// send that page back as the response.
> =A0 =A0 =A0 =A0 =A0 =A0response.setStatus(HttpServletResponse.SC_INTERNAL=
_SERVER_ERROR);
> =A0 =A0 =A0 =A0 =A0 =A0// The response is an error
> =A0 =A0 =A0 =A0 =A0 =A0response.setError();
>
> =A0 =A0 =A0 =A0 =A0 =A0status(request, response);
> =A0 =A0 =A0 =A0}
>
> It seems like this valve does not care if it handles an uncaught exceptio=
n or a deliberate exception.
> Can this be fixed without patching the valve?
>
> I guess not. I would file a ticket about that: A mere response#isError ca=
ll would suffice to wrap that behavior and pass the response as is.
>


My understanding is that it is responsibility of the Container to
provide the value for the request attribute
"javax.servlet.error.exception"

You cannot set it.

See 10.9.1 in Servlet 3.0 spec.

Can't you just throw new ServletException(PrivilegedActionException); ?

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org