Return-Path: X-Original-To: apmail-tomcat-users-archive@www.apache.org Delivered-To: apmail-tomcat-users-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DF2989149 for ; Fri, 2 Mar 2012 11:31:33 +0000 (UTC) Received: (qmail 94622 invoked by uid 500); 2 Mar 2012 11:31:30 -0000 Delivered-To: apmail-tomcat-users-archive@tomcat.apache.org Received: (qmail 94482 invoked by uid 500); 2 Mar 2012 11:31:30 -0000 Mailing-List: contact users-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Users List" Delivered-To: mailing list users@tomcat.apache.org Received: (qmail 94470 invoked by uid 99); 2 Mar 2012 11:31:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2012 11:31:30 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [209.85.210.173] (HELO mail-iy0-f173.google.com) (209.85.210.173) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2012 11:31:22 +0000 Received: by iafj26 with SMTP id j26so2937947iaf.18 for ; Fri, 02 Mar 2012 03:31:01 -0800 (PST) Received-SPF: pass (google.com: domain of fred@derf.nl designates 10.50.155.202 as permitted sender) client-ip=10.50.155.202; Authentication-Results: mr.google.com; spf=pass (google.com: domain of fred@derf.nl designates 10.50.155.202 as permitted sender) smtp.mail=fred@derf.nl Received: from mr.google.com ([10.50.155.202]) by 10.50.155.202 with SMTP id vy10mr1749242igb.8.1330687861870 (num_hops = 1); Fri, 02 Mar 2012 03:31:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.50.155.202 with SMTP id vy10mr1448547igb.8.1330687861805; Fri, 02 Mar 2012 03:31:01 -0800 (PST) Received: by 10.50.189.229 with HTTP; Fri, 2 Mar 2012 03:31:01 -0800 (PST) Date: Fri, 2 Mar 2012 12:31:01 +0100 Message-ID: Subject: Comment on RemoteIpValve documentation. From: Friedrich Clausen To: Tomcat Users List Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQmpCVpPtSesxo5AwZ0pvZxZ6FJQYrnBTbTEAO6LH0aSCZETUntplLhcUQHnWiAM6nrUguyr X-Virus-Checked: Checked by ClamAV on apache.org Hi All, Just a small comment on the docs at http://tomcat.apache.org/tomcat-6.0-doc/api/org/apache/catalina/valves/RemoteIpValve.html it would be great if it mentions that this valve should appear *before* any logging (unless I missed it), auth and other remote IP relevant valves. It took me quite a while to figure out why it was not working until I found this post - http://code.google.com/p/xebia-france/wiki/RemoteIpValve which mentioned the ordering. Thanks! Fred. --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org For additional commands, e-mail: users-help@tomcat.apache.org