tomcat-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: 7.0.22+ fd leak with APR/native
Date Tue, 03 Jan 2012 22:50:34 GMT
On 03/01/2012 21:32, Mark Thomas wrote:
> On 03/01/2012 21:26, André Warnier wrote:
>> Mark Thomas wrote:
>>> I am trying to bring together all the information I have gleaned on this
>>> so far from the multiple threads to try and find the common factors.
> 
> <snip/>
> 
>> Suggestion: the "large POST requests" mentioned by a couple of posters
>> suggest file uploads, which may imply temporary files used to buffer the
>> files being uploaded, no ?
> 
> Probably not. That code is connector agnostic. There might be something
> in the APR InputBuffer though.

The APR InputBuffer is untouched between 7.0.21 and 7.0.22. However, I
did find an error in r1166072 that might explain the fd leak. I am
trying to reproduce it at the moment. In the meantime, if someone could
try the following patch that would be great:

Index: java/org/apache/tomcat/util/net/AprEndpoint.java
===================================================================
--- java/org/apache/tomcat/util/net/AprEndpoint.java	(revision 1226551)
+++ java/org/apache/tomcat/util/net/AprEndpoint.java	(working copy)
@@ -1364,7 +1364,6 @@
                         } else {
                             destroySocket(desc[n*2+1]);
                         }
-                        return true;
                     }
                 }
             } else if (rv < 0) {


Cheers,

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org


Mime
View raw message