tomcat-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Francis GALIEGUE <...@one2team.com>
Subject Re: Request for comments: Apache-like allow/deny remote host filtering
Date Sun, 02 Oct 2011 19:57:32 GMT
On Sun, Oct 2, 2011 at 19:46, Konstantin Kolinko <knst.kolinko@gmail.com> wrote:
> 2011/10/2 Francis GALIEGUE <fge@one2team.com>:

>
> 1. If you want to submit it as a patch for Tomcat, you should attach
> it to a Bugzilla issue.

OK, will do.

> 2. Coding conventions:
> http://tomcat.apache.org/getinvolved.html
> 3. ASF software is collective work. @author tags are discouraged.
>

I was just copying existing code ;)

> 4. In Tomcat 7 there are  RemoteAddrValve and RemoteAddrFilter.  Both
> implement the same filtering, but one is implemented as a valve,
> another as a filter.

I hadn't seen that. Thanks for the correction!

> 5. Tomcat 7 has tests written for JUnit. I'd be nice if your valve had
> such tests.
> To start testsuite you execute the "test" target in Tomcat's build.xml.
>
> You can run a single test by setting "test.entry" property in
> build.properties equal to the test name. Otherwise the full testsuite
> will be run.
>

That's in the plan.

Thanks for the input,
-- 
Francis Galiegue
ONE2TEAM
Ingénieur système
Mob : +33 (0) 683 877 875
Tel : +33 (0) 178 945 552
fge@one2team.com
40 avenue Raymond Poincaré
75116 Paris

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org


Mime
View raw message