tomcat-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Francis GALIEGUE <...@one2team.com>
Subject Re: Request for comments: Apache-like allow/deny remote host filtering
Date Tue, 04 Oct 2011 18:50:16 GMT
On Tue, Oct 4, 2011 at 20:43, Christopher Schultz
<chris@christopherschultz.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Francis,
>
> On 10/2/2011 3:57 PM, Francis GALIEGUE wrote:
>> On Sun, Oct 2, 2011 at 19:46, Konstantin Kolinko
>> <knst.kolinko@gmail.com> wrote:
>>> 2011/10/2 Francis GALIEGUE <fge@one2team.com>:
>>
>>>
>>> 1. If you want to submit it as a patch for Tomcat, you should
>>> attach it to a Bugzilla issue.
>>
>> OK, will do.
>
> +1
>
> Is there a way to see the code as a diff instead of complete files?
> This looks like a diff where the whole file is new.
>

Indeed. Patch attached. I didn't know Bugzilla would treat patches this way...

[...]
>
> It appears that no changes would be needed to either the Filter or the
> Valve -- only to the shared implementation that interprets the meaning
> of those settings.
>

I implemented those two interfaces again, since the existing abstract
class wouldn't fit the bill (it only tried regexes). Or maybe I don't
understand what you actually mean?

[...]
>>>
>>> You can run a single test by setting "test.entry" property in
>>> build.properties equal to the test name. Otherwise the full
>>> testsuite will be run.
>>>
>>
>> That's in the plan.
>
> I don't see jmock in the set of libs available for TC7, so you may
> have to play some games with HttpServletRequestWrapper in order to
> test this thing properly.
>
> Let us know if you need any help.
>

Well, I need help precisely on the above... I have a hard time
figuring out how TestRemoteIP{Filter,Valve} work at all... But I've
been only having a superficial glance at them so far.

Have fun!
-- 
Francis Galiegue
ONE2TEAM
Ingénieur système
Mob : +33 (0) 683 877 875
Tel : +33 (0) 178 945 552
fge@one2team.com
40 avenue Raymond Poincaré
75116 Paris

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org


Mime
View raw message