tomcat-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: Logging properties of attributes in the HttpSession
Date Mon, 03 Oct 2011 20:16:25 GMT
2011/10/3 Christopher Schultz <chris@christopherschultz.net>:
> On 9/30/2011 2:18 PM, Konstantin Kolinko wrote:
>> 2011/9/30 Christopher Schultz <chris@christopherschultz.net>:
>>> The OP should be able to put the Filter into the <Context> in
>>> such a way that the Filter wraps the AccessLogValve, no?
>>>
>>
>> 1. You cannot put a Filter into Context.
>
> Mmm. Why do I always think that you can do this sort of thing? Maybe
> I'll log an enhancement that allows us to do this: it seems reasonable
> to allow Filters to be interspersed with Valves, especially for things
> like this.

This:
https://issues.apache.org/bugzilla/show_bug.cgi?id=51754
worries me a bit more.

>
>> 3. A Valve can modify a Request, while Filter cannot.
>
> Both Filter and Valve can wrap the request, which can be seen as
> "modifying" it, though it's not really modifying it.

Valve has access to o.a.c.connector.Request object, which is modifiable.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org


Mime
View raw message