tomcat-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: ExtendedAccessLogValve, documentation
Date Thu, 21 Jul 2011 10:58:41 GMT
2011/7/21 André Warnier <aw@ice-sa.com>:
> Hi.
>
> I just looked at this, and have the following questions/suggestions :
>
> 1) suffix
> 3) x-H(requestedSessionId): getGequestedSessionId      (typo ?)

Fixed in r1149104.


> 2) condition
>
> current:
> Turns on conditional logging. (...)
> suggestion:
> Intuitively, should it not be the opposite ?

You cannot change this feature. It is there for ages.

IIRC, there exists an enhancement request to provide a pair of
separate attributes, for exists and not exists checks. I think those
can be named "if" and "unless", but you should keep the old name as
well for compatibility. Patches are welcome.

Also note that if I understand correctly the current Tomcat 7 does not
support more than 1 access log valve per scope (context, host, ...).
Nobody complained about this yet though.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org


Mime
View raw message