tomcat-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Riggs <apache-li...@riggs.me>
Subject Re: RemoteIP valve and multiple X-Forwarded-For headers
Date Fri, 10 Dec 2010 14:42:23 GMT
On Dec 10, 2010, at 7:59 AM, Mark Thomas wrote:

>> Looks like a bug,
>> 
>> Please add it to bugzilla, as Mark suggested.
>> 
>> BTW, I think that the following change can fix it:
>> (for current tc6.0.x, not tested!)
> 
> I don't think so. I think the problem is further up on line 558:
> String[] remoteIpHeaderValue =
> commaDelimitedListToStringArray(request.getHeader(remoteIpHeader));
> 
> I'm pretty sure that needs to be using request.getHeaders() but I
> haven't tested it either ;)

It does indeed need to be using the Enumeration from request.getHeaders() instead of the single
value from getHeader().  I have started work on a patch, unless someone beats me to it...


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org


Mime
View raw message