tomcat-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Schultz <ch...@christopherschultz.net>
Subject RequestDumperFilter improvement
Date Fri, 12 Nov 2010 20:51:03 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

All,

I would like to propose a new feature for the RequestDumperFilter that
is similar to the AccessLogValve's "condition" setting, except that it
is logically opposite: it would be nice to allow a Filter ahead of the
RequestDumperFilter in the chain to flag the request as dump-able
instead of having to clear-out a flag: presumably, the act of
conditionally dumping a request is rare and so the semantics seem
reasonable to work opposite to AccessLogValve's "condition".

So, I can submit a patch that does this but the question is what to call
the configuration attribute. I have several options:

1. "condition". This may cause confusion as it acts the opposite way
   to AccessLogValve's "condition".

2. "ifSet" or even "if"

3. Give the user a choice: "ifSet" /and/ "ifUnset" (or both!)

Does anyone care either way?

Thanks,
- -chris
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkzdqLcACgkQ9CaO5/Lv0PBk+wCcDDeUubB+EWMTIUhNR/TRNe1h
JMcAoIMVDVoj2BtK3VTauD3zlAxfWTf6
=vApy
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org


Mime
View raw message