Mailing-List: contact users-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Users List" <users@tomcat.apache.org>
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <4AC5CDF4.1070804@apache.org>
Date: Fri, 02 Oct 2009 10:55:00 +0100
From: Mark Thomas <markt@apache.org>
User-Agent: Thunderbird 2.0.0.23 (Windows/20090812)
MIME-Version: 1.0
To: Tomcat Users List <users@tomcat.apache.org>
Subject: Re: Cannot set remote address in valve (Tomcat 5.5)
References: <4B7A3AA67FB2456E8F477D96BCDBF8FF@ealbek>
 <4ABF7789.1010308@cornell.edu> <6FA924FC646B45319F42E7207C67BC44@ealbek>
In-Reply-To: <6FA924FC646B45319F42E7207C67BC44@ealbek>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Elli Albek wrote:
> A few reasons why not to do this as a servlet filter:
> 
> 1. There are many web apps on the server and I don't want to include the
> filter in each.
You don't have to. Configure it in the global web.xml.

> 2. There are other valves like request filters that cannot work without the
> correct IP, as well as custom login valve.
Filters should be OK providing they are defined in the right order.

The valve is a problem and that does limit your options. This should be
better in Tomcat 7 where the Servlet spec includes programmatic login so
you might be able to move your valve to a filter.

> 3. We have a few environments and I don't want to have different war
> configurations for each. We had servers with and without load balancers and
> I can see that change again in the near future. This should not affect the
> application configuration.
Essentially the same issue as 1 - setting the filter globally should
address this.

> 4. It is logically part of the server environment and not part of the web
> application. The web application should not change based on the network
> architecture. If the system admin adds/removes the load balancer then he
> should know about one thing he needs to change in tomcat, and not rebuild
> all the wars without a filter. Network configuration should not require code
> rebuild with/without filters (we have to do a build to create war, like most
> people).
Same as 3.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org