Mailing-List: contact users-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Users List" <users@tomcat.apache.org>
Received-SPF: pass (athena.apache.org: domain of knst.kolinko@gmail.com
 designates 209.85.218.177 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=RL2bRhtfsMtnU/1QoyNl5rB0pYBrqS5uJptMNCfBZ3tyS1RM75KWFkuaPqcwDnGiwC
         RPSNTKi0Qy5h/2aPxrFCNP1msCV5y2hTi95rnT+7gJbHsLG/8ROU5Q9ZXHMj5DDd5PTZ
         skaOhIBasp8uAAV3aywxfonUmpI4apyZjW4aY=
MIME-Version: 1.0
In-Reply-To: <4A0827A8.6070103@verizon.net>
References: <4A0827A8.6070103@verizon.net>
Date: Mon, 11 May 2009 17:47:41 +0400
Message-ID: <427155180905110647p510d4ed3wb07ee0fdee6f494f@mail.gmail.com>
Subject: Re: Trouble parsing datetime strings
From: Konstantin Kolinko <knst.kolinko@gmail.com>
To: Tomcat Users List <users@tomcat.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

2009/5/11 David kerber <dckerber@verizon.net>:
> This is related to the performance issues discussed in the thread
> "Performance with many small requests".
>
> When I reworked my servlet to synchronize only on pieces that needed to b=
e
> synchronized, rather than on the entire request processing routine, I am =
now
> throwing an exception when parsing a string into a java.util.Date variabl=
e.
> =A0It only happens occasionally, maybe once every few dozen to a hundred =
or so
> requests, and I can't figure out why it doesn't work all the time.
>
> Declared at the class level, I have:
>
> =A0 private static final SimpleDateFormat =A0 =A0sdfFullDateTime =3D new
> SimpleDateFormat( "yyyy-MM-dd HH:mm:ss" );
>
>
> Then in the request processing method, I have
>
> =A0 dateTimeStr =3D dateStr + " " + timeStr;
> =A0 try {
> =A0 =A0 =A0 dataDate =3D sdfFullDateTime.parse( dateTimeStr );
> =A0 } catch ( Exception e ) {
> =A0 =A0 =A0 writeLog( "Unable to parse dataTime string: '", dateTimeStr +=
 "': " +
> e );
> =A0 }
>
>
> (the try/catch is there only for debugging this issue), and in the log I'=
m
> seeing:
>
> 2009-05-11 09:19:54: Unable to parse dateTime string: ': =A0'2009-05-11
> 09:19:37': java.lang.NumberFormatException: For input string: ""'
>
>
> Which I don't understand at all; dateDate (java.util.Date), dateStr
> (String), timeStr (String) and dateTimeStr (String) are all declared in t=
he
> processing method, NOT at the class level.
>
> Maybe I should move the declaration of the SimpleDateFormat into the
> processing method? =A0Or synchronize the date parse?
>
>
> I'm kind of lost here; any help appreciated!!
>
> Dave
>

As the JavaDoc says
http://java.sun.com/javase/6/docs/api/java/text/SimpleDateFormat.html

"Date formats are not synchronized. It is recommended to create
separate format instances for each thread"

You may either create a new instance of SimpleDateFormat each time, or
add a synchronization around that part of code, or use a ThreadLocal
(though ThreadLocal has its own caveats as the threads belong to
Tomcat and are shared among applications).

Without profiling you would not know which one of the ways I am
mentioning is faster.

Maybe I would start with creating a new instance each time, as GC for
short-living objects seems to be cheap in recent JREs. Though without
profiling you will not get the numbers.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org