tomcat-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Walker Chris <walk...@dc-link.co.uk>
Subject RE: Tomcat sucks at receiving large messages
Date Wed, 01 Oct 2003 08:21:06 GMT
Hi,

I should have thought that as a general principle it's not a good idea to
try to store the response in a byte array.  I recently worked on a piece of
code that did just that (worse, actually, it then copied the array into a
String).  Sooner or later a really big upload will blow up the application.

Reading and writing a byte at a time (with appropriate buffering) requires a
bit more ingenuity, especially when you're searching for things like
boundary strings in the response, but it's the only way to remove any
constraint on upload size.  

Chris Walker

-----Original Message-----
From: Shapira, Yoav [mailto:Yoav.Shapira@mpi.com]
Sent: 30 September 2003 19:30
To: Tomcat Users List
Subject: RE: Tomcat sucks at receiving large messages



Howdy,

>public void service(HttpServletRequest req, HttpServletResponse res) {
>  BufferedReader reader = req.getReader();
>  try {
>    char [] charArr = new char[req.getContentLength()];
>    reader.read(charArr);
>    String str = new String(charArr);
>
>    try {
>      File f = new File("servlet.out");
>      PrintWriter out = new PrintWriter(new FileWriter(f));
>      out.print(str);
>      out.flush();
>      out.close();
>    } catch(IOException err { System.err.println(err.toString()); }
>
>  } catch(IOException err) { System.err.println(err.toString()); }
>}

What happens if you ditch the req.getContentLength() approach (there are
times when it will be -1 anyways), and do something like:
BufferedReader reader = req.getReader();
StringBuffer contents = new StringBuffer();
String line = null;
while((line = reader.readLine()) != null) {
  contents.append(line);
}

System.out.println(contents);

(Later we'll worry about the writing -- first make sure you're reading
the entire contents).

Yoav Shapira



This e-mail, including any attachments, is a confidential business
communication, and may contain information that is confidential, proprietary
and/or privileged.  This e-mail is intended only for the individual(s) to
whom it is addressed, and may not be saved, copied, printed, disclosed or
used by anyone else.  If you are not the(an) intended recipient, please
immediately delete this e-mail from your computer system and notify the
sender.  Thank you.


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-user-help@jakarta.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-user-help@jakarta.apache.org


Mime
View raw message