tomcat-taglibs-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henri Yandell <bay...@generationjava.com>
Subject RE: FW: String TagLib 1.0 wordWrap StringIndexArrayOutOfBoundsException (Bug#15321)
Date Tue, 28 Jan 2003 23:06:41 GMT

Okay, was an odd bug :) It occured on the 80th, 155th, 259th, 497th,
591st... element. Which might just be dependent on the random string i was
throwing into it.

Anyways, I've protected against it, and after I commit it'll go into
tonight's nightly build. I've only tested the underlying Java util class,
but it's there where the real bug is. The taglib should reflect the fix
fine.

wordWrap is one of those methods I know I should have done with far more
beauty, but it's managed to evolve to pretty much do what it's meant to. I
overestimated the pain of this bug I think :)

Let me know if this fixes things for you tomorrow,

Hen

On Tue, 28 Jan 2003, Robert Taylor wrote:

> No worries. Thanks for a very useful tag library!
>
> robert
>
> -----Original Message-----
> From: Henri Yandell [mailto:bayard@generationjava.com]
> Sent: Tuesday, January 28, 2003 5:41 PM
> To: Tag Libraries Users List
> Subject: Re: FW: String TagLib 1.0 wordWrap
> StringIndexArrayOutOfBoundsException (Bug#15321)
>
>
>
> Nope. I'll get on it now. Sorry about that.
>
> Hen
>
> On Tue, 28 Jan 2003, Robert Taylor wrote:
>
> > Has anyone addressed this bug yet?
> >
> > robert
> >
> > -----Original Message-----
> > From: Robert Taylor [mailto:rtaylor@newatlanta.com]
> > Sent: Thursday, December 12, 2002 11:58 AM
> > To: Tag Libraries Users List
> > Subject: RE: String TagLib 1.0 wordWrap
> > StringIndexArrayOutOfBoundsException
> >
> >
> > Okay. I entered it as a bug. See bug #15321.
> >
> > robert
> >
> > -----Original Message-----
> > From: Henri Yandell [mailto:bayard@generationjava.com]
> > Sent: Thursday, December 12, 2002 11:24 AM
> > To: Tag Libraries Users List
> > Subject: Re: String TagLib 1.0 wordWrap
> > StringIndexArrayOutOfBoundsException
> >
> >
> >
> > Hey Robert,
> >
> > This is my fault, I need to somehow document that the wordWrap method is a
> > bit suss. Certain combinations of characters in different positions can
> > make it blow up, while the rest of the time it sails on through. It's
> > definitely nothing you are doing but just dodginess in the underlying
> > word-wrapping code.
> >
> > If you could push this into bugzill as a bug, hopefully it'll help kick me
> > into refactoring and unit-testing that method.
> >
> > Most of String-taglib is in Commons Lang now [the underlying code], so
> > it's well unit-tested there, but wordWrap and a couple of other methods
> > are not.
> >
> > [quoteRegularExpression, wordWrap and truncateNicely]
> > [metaphone and soundex are in Commons Codec, but not released there yet]
> > [xml functions are not in Commons Lang]
> >
> > Sorry for the bugs, coder's fault.
> >
> > Hen
> >
> > On Thu, 12 Dec 2002, Robert Taylor wrote:
> >
> > > I just downloaded the String Tag Lib 1.0 binaries and started using the
> > > wordWrap functionality.
> > >
> > > It seems to be blowing up if the tag attempts to wrap a string that
> > > contains a newline character as the 81st character. It will not blow up
> > > if the 81st character is not a new line character.
> > >
> > > This is my usage:
> > > <string:wordWrap><bean:write name="form" property="body"
> > > ignore="true"/></string:wordWrap>
> > >
> > > Partial stack trace:
> > > 2120: java.lang.StringIndexOutOfBoundsException: String index out of
> > range:
> > > 80
> > > 2120:   at java.lang.String.charAt(String.java:455)
> > > 2120:   at
> > org.apache.taglibs.string.util.StringW.wordWrap(StringW.java:181)
> > > 2120:   at
> > > org.apache.taglibs.string.WordWrapTag.changeString(WordWrapTag.java:159)
> > > 2120:   at
> > >
> >
> org.apache.taglibs.string.StringTagSupport.doEndTag(StringTagSupport.java:13
> > > 5)
> > >
> > > Has anyone else had this problem. I search bugzilla and didn't find any
> > bugs
> > > mentioned.
> > >
> > >
> > > robert
> > >
> > >
> > > --
> > > To unsubscribe, e-mail:
> > <mailto:taglibs-user-unsubscribe@jakarta.apache.org>
> > > For additional commands, e-mail:
> > <mailto:taglibs-user-help@jakarta.apache.org>
> > >
> > >
> >
> >
> > --
> > To unsubscribe, e-mail:
> > <mailto:taglibs-user-unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail:
> > <mailto:taglibs-user-help@jakarta.apache.org>
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
> > <mailto:taglibs-user-unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail:
> > <mailto:taglibs-user-help@jakarta.apache.org>
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
> <mailto:taglibs-user-unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail:
> <mailto:taglibs-user-help@jakarta.apache.org>
> >
> >
>
>
> --
> To unsubscribe, e-mail:
> <mailto:taglibs-user-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail:
> <mailto:taglibs-user-help@jakarta.apache.org>
>
>
>
> --
> To unsubscribe, e-mail:   <mailto:taglibs-user-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:taglibs-user-help@jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <mailto:taglibs-user-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:taglibs-user-help@jakarta.apache.org>


Mime
View raw message