From dev-return-203570-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Wed Nov 20 14:03:40 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 57BFC1804BB for ; Wed, 20 Nov 2019 15:03:40 +0100 (CET) Received: (qmail 86597 invoked by uid 500); 20 Nov 2019 14:03:39 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 86584 invoked by uid 99); 20 Nov 2019 14:03:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Nov 2019 14:03:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 659F5181385 for ; Wed, 20 Nov 2019 14:03:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.3 X-Spam-Level: X-Spam-Status: No, score=0.3 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id dXdJnn1hxf-K for ; Wed, 20 Nov 2019 14:03:37 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::12e; helo=mail-lf1-x12e.google.com; envelope-from=knst.kolinko@gmail.com; receiver= Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 957587DE07 for ; Wed, 20 Nov 2019 14:03:36 +0000 (UTC) Received: by mail-lf1-x12e.google.com with SMTP id f16so1175906lfm.3 for ; Wed, 20 Nov 2019 06:03:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=KbC+WwC1qopuZPORE2jPb7Xo9H2saPGPd2iQTYjEq7U=; b=W+yiyYJYXLEl83aTaOL6o1rqzodIF7bSuqdowXPSeWCCyrClFdvqlBYRkNlJO5WQBm sZY/Fk7Y0AdfBqwtD8JcVb/Ry2lrC1Nxii3ebxjXqK/Aa8SNns6Ti5S1EzzQ6NF5/Iy5 OOgUnUSznJ0KTIT/6N5Psy7UuSj9aA3iQp/gPp6MrnlRgZfKloyepp/NyYN5QQIB+BWT iXS5fSQUkyr67FQbRlMbIpcJUdtaaV2AoQS4huOypgoZR3KNkwVPEFJUzEoNXg7WAOcW b659DnyaUGT4S8E74givH/N5yOvLahUMw6QElQo40iea0dOkiF+7L7r3NVQxD7gT700P qQvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=KbC+WwC1qopuZPORE2jPb7Xo9H2saPGPd2iQTYjEq7U=; b=PPWJ8QyaQdiEF4EwShL9Z1IRBAFqLxDDV8XRLYRUthTo91x9e22Tm8h8f6zYBpbjD9 +k2qxTgvYTw8DybvOZ0tOM2DhrM48KBZv7FZf0b63ykheiW6N8Hi/n5VanCrQlJ9aTAE FxmlEOveOvwxx0wTmKIIXp1fVQ69B2QzOlYmFRxwskgkxsC22q1+zxQh4lb6HxCtphT+ /3gPpBRH3M1kuZ2tzkfHAQJ9QZgsO381hoWWCFtU4v2zqHNXTntStlBLzGorvtb3A43i MTiuKfBtqRBiVJeWBygHfPHaJU7bSlKV3OF8WHQKY2ZnNsSE9HX00mtLRs0kRsp/PcUY YCDg== X-Gm-Message-State: APjAAAXluRcGb91t8UKA/LTLwhUCXknXm/Ln5yqXlNESRel92/7bLNe8 t9VJnt9h8Ub3Kav3mloYWCt1/aZzOH5wQpfIZD/o/DT+8Qo= X-Google-Smtp-Source: APXvYqy4bEE65dTQzMsBI6+g4mo4Lp+MBD1SpsiovzOBRcWv9U5kt+T6d30J1/DJanjD8mvauph2H+2BndZVbVyz7dg= X-Received: by 2002:a05:6512:486:: with SMTP id v6mr2798131lfq.72.1574258615499; Wed, 20 Nov 2019 06:03:35 -0800 (PST) MIME-Version: 1.0 References: <0d0b6c35-469f-049a-5e79-eac2bbd06b0b@apache.org> <0eaa0a43-a240-8f46-e436-0345308653ba@apache.org> In-Reply-To: <0eaa0a43-a240-8f46-e436-0345308653ba@apache.org> From: Konstantin Kolinko Date: Wed, 20 Nov 2019 17:03:24 +0300 Message-ID: Subject: Re: [VOTE] Release Apache Tomcat 8.5.49 To: Tomcat Developers List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =D0=B2=D1=82, 19 =D0=BD=D0=BE=D1=8F=D0=B1. 2019 =D0=B3. =D0=B2 19:58, Mark = Thomas : > > On 19/11/2019 00:44, Konstantin Kolinko wrote: > > =D0=B2=D1=82, 19 =D0=BD=D0=BE=D1=8F=D0=B1. 2019 =D0=B3. =D0=B2 01:42, M= ark Thomas : > > > > I think the single pollset change should not be backported to Tomcat 7. > > I am OK with it being backported to Tomcat 8.5. > > In favour of back-porting: > [...] > - Windows XP / Server 2003 are out of support. I think it would be > unusual for a user to be keeping Tomcat up to date but not the OS. > - sendfile is already using a larger pollset size and we have had no > complaints (that I recall) Updating an OS costs money (if it is Windows) and may be not possible due to hardware limitations. That said, reviewing the changes and comments once again, I see that this is not a showstopper for Windows XP users, if there are any= . The comments say about reduced performance, not an inability to run Tomcat. The pollset size can be adjusted by configuring maxConnections=3D"1024" or less. I think that is a reasonable value for some legacy server. Thus OK to backport to Tomcat 7. Looking into documentation, http://tomcat.apache.org/tomcat-7.0-doc/config/http.html Regarding maxConnections it says "Note that for APR/native on Windows, the configured value will be reduced to the highest multiple of 1024 that is less than or equal to maxConnections." I think that is no longer true. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org