tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tomcat] michael-o commented on a change in pull request #225: BZ 63681: Introduce RealmBase#authenticate(GSSName, GSSCredential) an…
Date Fri, 22 Nov 2019 16:31:40 GMT
michael-o commented on a change in pull request #225: BZ 63681: Introduce RealmBase#authenticate(GSSName,
GSSCredential) an…
URL: https://github.com/apache/tomcat/pull/225#discussion_r349685255
 
 

 ##########
 File path: java/org/apache/catalina/Realm.java
 ##########
 @@ -116,6 +118,17 @@ public Principal authenticate(String username, String digest,
     public Principal authenticate(GSSContext gssContext, boolean storeCreds);
 
 
+    /**
+     * Try to authenticate using a {@link GSSName}
+     *
+     * @param gssName The {@link GSSName} of the principal to look up
+     * @param gssCredential The {@link GSSCredential} of the principal, may be
+     *                      {@code null}
+     * @return the associated principal, or {@code null} if there is none
+     */
+    public Principal authenticate(GSSName gssName, GSSCredential gssCredential);
+
 
 Review comment:
   That is true, but that would ultimately mean that it would be available in Tomcat 9+ only.
SPNEGO support has been introduced with BZ 48685 which was first implemented in 577c4e6194b71a63be70725bb743c94c7cb082cc
and was included in these tags:
   
   ```
   $ git tag --contains 577c4e6194b71a63be70725bb743c94c7cb082cc
   7.0.12
   7.0.13
   7.0.14
   7.0.15
   7.0.16
   7.0.17
   7.0.18
   7.0.20
   9.0.0
   9.0.0-M1
   9.0.0-M10
   9.0.0-M11
   9.0.0-M12
   9.0.0-M13
   9.0.0-M14
   9.0.0-M15
   9.0.0-M16
   9.0.0-M17
   9.0.0-M18
   9.0.0-M19
   9.0.0-M2
   9.0.0-M20
   9.0.0-M21
   ```
   
   which basically means that the API has already been broken. I wouldn't mind to provide
this to 8.5.x and 9.0.x only. Since 8.5.x and 9.0.x are interchangeable expect Servlet API
it would be whise to have it either in both or in none.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message