tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tomcat] michael-o commented on issue #218: WIP: BZ 63835: Add support for Keep-Alive header
Date Sun, 10 Nov 2019 00:28:20 GMT
michael-o commented on issue #218: WIP: BZ 63835: Add support for Keep-Alive header
URL: https://github.com/apache/tomcat/pull/218#issuecomment-552150379
 
 
   Tests added, they pass now. Though, I might have also found a bug in Tomcat or in the `SimpleHttpClient`.
Test `testKeepAliveHeader04(org.apache.coyote.http11.TestHttp11Processor)` blocks forever
as soon as you say `client.processRequest(true)`. JConsole shows me
   
   ```
   Name: main
   State: RUNNABLE
   Total blocked: 9  Total waited: 126
   
   Stack trace: 
   java.net.SocketInputStream.socketRead0(Native Method)
   java.net.SocketInputStream.socketRead(SocketInputStream.java:116)
   java.net.SocketInputStream.read(SocketInputStream.java:171)
   java.net.SocketInputStream.read(SocketInputStream.java:141)
   sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:284)
   sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:326)
   sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178)
      - locked java.io.InputStreamReader@2ca2d2a1
   java.io.InputStreamReader.read(InputStreamReader.java:184)
   java.io.BufferedReader.fill(BufferedReader.java:161)
   java.io.BufferedReader.readLine(BufferedReader.java:324)
      - locked java.io.InputStreamReader@2ca2d2a1
   java.io.BufferedReader.readLine(BufferedReader.java:389)
   org.apache.catalina.startup.SimpleHttpClient.readLine(SimpleHttpClient.java:384)
   org.apache.catalina.startup.SimpleHttpClient.processBody(SimpleHttpClient.java:316)
   org.apache.catalina.startup.SimpleHttpClient.readResponse(SimpleHttpClient.java:260)
   org.apache.catalina.startup.SimpleHttpClient.processRequest(SimpleHttpClient.java:209)
   org.apache.coyote.http11.TestHttp11Processor.doTestKeepAliveHeader(TestHttp11Processor.java:1577)
   org.apache.coyote.http11.TestHttp11Processor.testKeepAliveHeader04(TestHttp11Processor.java:1535)
   ```
   
   `keepAliveTimeout` has to be set to `-1`.
   
   If no one objects, I will backport to 8.5.x and 7.0.x and merge.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message