tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rémy Maucherat <r...@apache.org>
Subject Re: open visibility of JavaClassCacheEntry
Date Thu, 06 Dec 2018 13:13:19 GMT
On Thu, Dec 6, 2018 at 11:51 AM Romain Manni-Bucau <rmannibucau@gmail.com>
wrote:

> Hi guys,
>
> can you make ContextConfig.JavaClassCacheEntry public please? Idea is to be
> able to override ContextConfig and potentially customize processAnnotations
> methods. Currently it is a pain and it is preventing to upgrade meecrowave
> and likely tomee to java11+jlink support
>

Ok, so I had a look at the meecrowave main class after doing my embedded
refactoring and I was a bit horrified by the amount of hacks :) Not that
there were too many options to do the things that were done (some I didn't
think were possible), and luckily my changes would have been a very good
help there.

So here, it looks like a bit scary as well, since JavaClassCacheEntry is
package private (not ok usually), but only instantiated from a private
method (what would you do about that ?). So I'd rather not do that, or not
just that, since it would be good to reduce the amount of hacks.

For starters, I don't like "private" in that kind of class (same with
"final"), I prefer "protected" usually. Shouldn't JavaClassCacheEntry be a
non static protected class ?

About webConfig, I'm not sure. A good way to do it would be to add calls to
a few intermediate empty methods in appropriate locations, rather than a
real refactoring.

Rémy

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message