From dev-return-193940-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Tue Oct 9 20:56:18 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9CF14180668 for ; Tue, 9 Oct 2018 20:56:17 +0200 (CEST) Received: (qmail 1658 invoked by uid 500); 9 Oct 2018 18:56:16 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 1648 invoked by uid 99); 9 Oct 2018 18:56:16 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Oct 2018 18:56:16 +0000 Received: from [192.168.23.12] (host86-152-79-27.range86-152.btcentralplus.com [86.152.79.27]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id A9EBBEF0 for ; Tue, 9 Oct 2018 18:56:15 +0000 (UTC) Subject: Re: svn commit: r1843328 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java From: Mark Thomas To: dev@tomcat.apache.org Reply-To: Tomcat Developers List References: <20181009185518.03EDF3A028E@svn01-us-west.apache.org> Message-ID: <357019f5-4bce-4138-cd99-f798af20da7e@apache.org> Date: Tue, 9 Oct 2018 19:56:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181009185518.03EDF3A028E@svn01-us-west.apache.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit On 09/10/18 19:55, markt@apache.org wrote: > Author: markt > Date: Tue Oct 9 18:55:17 2018 > New Revision: 1843328 > > URL: http://svn.apache.org/viewvc?rev=1843328&view=rev > Log: > Fix unused code warning My IDE popped up a warning that this parameter was unused. I think I have fixed this correctly but additional review would be good here. Mark > > Modified: > tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java > > Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java > URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java?rev=1843328&r1=1843327&r2=1843328&view=diff > ============================================================================== > --- tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java (original) > +++ tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java Tue Oct 9 18:55:17 2018 > @@ -90,7 +90,7 @@ public class CertificateStreamProvider e > String alias = cert.getSubjectX500Principal().getName(); > keyStore.setKeyEntry(alias, privKey, clientKeyPassword, new Certificate[]{cert}); > > - KeyManagerFactory keyManagerFactory = KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm()); > + KeyManagerFactory keyManagerFactory = KeyManagerFactory.getInstance(clientKeyAlgo); > keyManagerFactory.init(keyStore, clientKeyPassword); > > return keyManagerFactory.getKeyManagers(); > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org > For additional commands, e-mail: dev-help@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org