tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m-czernek <...@git.apache.org>
Subject [GitHub] tomcat pull request #125: Provide port offset functionality (BZ-61171)
Date Sun, 07 Oct 2018 12:42:03 GMT
GitHub user m-czernek opened a pull request:

    https://github.com/apache/tomcat/pull/125

    Provide port offset functionality (BZ-61171)

    This PR resolves [BZ61171](https://bz.apache.org/bugzilla/show_bug.cgi?id=61171) and adds
the port offset functionality.
    
    The implementation is deliberately done such that the current behavior is left unchanged,
i.e. `getPort()` always returns the port without offset. However, if you set `portOffset`
on the `StandardServer` element, all connectors get the offset, and are listening at port+portOffset
port. To get port with offset, one specifically has to call `getPortWithOffset()`. This behavior
is also signified in the logs, which now show, for example, `"http-nio-8080-offset-100"` rather
than `"http-nio-8180"`.
    
    User-facing documentation will follow when and if this PR gets merged.
    
    Thoughts? As always, I'm keen on feedback and request for changes. Alternatively, feel
free to change any part of the PR. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/m-czernek/tomcat bz61171_portOffset

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomcat/pull/125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #125
    
----
commit a9162b7112719a5cb649af2cc673239db92b5f0e
Author: Marek Czernek <mczernek@...>
Date:   2018-02-13T15:19:34Z

    Provide port offset functionality

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message