tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1843328 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java
Date Tue, 09 Oct 2018 18:56:14 GMT
On 09/10/18 19:55, markt@apache.org wrote:
> Author: markt
> Date: Tue Oct  9 18:55:17 2018
> New Revision: 1843328
> 
> URL: http://svn.apache.org/viewvc?rev=1843328&view=rev
> Log:
> Fix unused code warning

My IDE popped up a warning that this parameter was unused. I think I
have fixed this correctly but additional review would be good here.

Mark


> 
> Modified:
>     tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java
> 
> Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java?rev=1843328&r1=1843327&r2=1843328&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java
(original)
> +++ tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java
Tue Oct  9 18:55:17 2018
> @@ -90,7 +90,7 @@ public class CertificateStreamProvider e
>              String alias = cert.getSubjectX500Principal().getName();
>              keyStore.setKeyEntry(alias, privKey, clientKeyPassword, new Certificate[]{cert});
>  
> -            KeyManagerFactory keyManagerFactory = KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm());
> +            KeyManagerFactory keyManagerFactory = KeyManagerFactory.getInstance(clientKeyAlgo);
>              keyManagerFactory.init(keyStore, clientKeyPassword);
>  
>              return keyManagerFactory.getKeyManagers();
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message