From dev-return-191959-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Tue Jul 3 20:09:54 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A8582180632 for ; Tue, 3 Jul 2018 20:09:53 +0200 (CEST) Received: (qmail 50892 invoked by uid 500); 3 Jul 2018 18:09:47 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 50882 invoked by uid 99); 3 Jul 2018 18:09:47 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jul 2018 18:09:47 +0000 Received: from [192.168.1.13] (p548F9B98.dip0.t-ipconnect.de [84.143.155.152]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 8665ECED for ; Tue, 3 Jul 2018 18:09:46 +0000 (UTC) To: dev@tomcat.apache.org From: Michael Osipov Subject: Inconsistencies makebase.sh Message-ID: <21930a57-fdfc-774e-3eee-6330e6e9a082@apache.org> Date: Tue, 3 Jul 2018 20:09:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Friends, I still see some inconsistencies and portability issues: 1. Some expressions, some are not. It should be consistently quoted to avoid whitespace issues or similar. 2. "cp -a" is not portable. Some platforms don't have it, e.g., HP-UX which I use for approx 10 years with Tomcat. 3. Evaluation uses sometimes backticks sometimes $(). Seems inconsistent. Michael --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org