tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 62312] Add Proxy Authentication support to websocket client
Date Tue, 24 Apr 2018 12:38:24 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=62312

--- Comment #3 from Mark Thomas <markt@apache.org> ---
Please provide a diff against trunk rather than a sequence of patch files.

Please remove all the getString {n} changes from the proposed diff.
Substitution is correctly handled by Tomcat's StringManager implementation.

The patch is not using the StringManager correctly. New strings need to be
defined in LocalStrings.properties

Please add ALv2 headers (as per the Tomcat source files) to all new files.

Please remove all @author tags.

Please document the new properties in web-socket-howto.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message