From dev-return-189875-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Thu Mar 29 14:33:12 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4B557180645 for ; Thu, 29 Mar 2018 14:33:12 +0200 (CEST) Received: (qmail 34547 invoked by uid 500); 29 Mar 2018 12:33:11 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 34536 invoked by uid 99); 29 Mar 2018 12:33:11 -0000 Received: from mail-relay.apache.org (HELO mailrelay2-lw-us.apache.org) (207.244.88.137) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Mar 2018 12:33:11 +0000 Received: from Christophers-MacBook-Pro.local (pool-173-66-120-163.washdc.fios.verizon.net [173.66.120.163]) by mailrelay2-lw-us.apache.org (ASF Mail Server at mailrelay2-lw-us.apache.org) with ESMTPSA id 55403FBD for ; Thu, 29 Mar 2018 12:33:10 +0000 (UTC) Subject: Re: DBCP2 in Tomcat To: dev@tomcat.apache.org References: From: Christopher Schultz Message-ID: Date: Thu, 29 Mar 2018 08:33:09 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Xkbk1b7HAn6kxKBY2fb9D7SczkdQfNvPj" --Xkbk1b7HAn6kxKBY2fb9D7SczkdQfNvPj Content-Type: multipart/mixed; boundary="6fNlsS3LLBkMgzaSVQgE5mDLVrkbTNyXg"; protected-headers="v1" From: Christopher Schultz To: dev@tomcat.apache.org Message-ID: Subject: Re: DBCP2 in Tomcat References: In-Reply-To: --6fNlsS3LLBkMgzaSVQgE5mDLVrkbTNyXg Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable R=C3=A9my, On 3/28/18 2:25 PM, R=C3=A9my Maucherat wrote: > Hi, >=20 > In Tomcat, DBCP2 is missing the XA portion (all contained in a single > "managed" package). So at work I now got some people asking about that > removal, and that's always a bit annoying as they have to go to a separ= ate > vanilla DBCP2 to get the functionality. Annoying sometimes. >=20 > So it would be possible to add the classes in Tomcat (including the > javax.transaction to build, as that's the Tomcat way to deal with that)= , > even though the user would need to add its own transaction manager to d= o > anything with it. >=20 > Should I now add it (only in 9/trunk) or instead leave things the way t= hey > are ? Both work to be honest, it's just that I've been bitten by the "w= e > only ship 3/4 of DBCP and I didn't know it" bug. I've always wondered why we bother to package-rename DBCP2 and check-in the source into our svn repo (soon to be Git). Why not pull DBCP2 from source during the build and re-name it on the fly? -chris --6fNlsS3LLBkMgzaSVQgE5mDLVrkbTNyXg-- --Xkbk1b7HAn6kxKBY2fb9D7SczkdQfNvPj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlq83QUACgkQHPApP6U8 pFiYdA/7Bqe5ldQEfqMdys2boyfbv+RLBXlj6SxIZJH5hAw3+2ArvxisVkk0DbS1 k5kNLMKm7RqCSJd7iEXO4rMfhFH9UHfzOHOpfQXG4ffR0Je1j+oZlzL9ZDgZG9q8 0oVLpmFWyKf54gTqLF0cp33plaNZ/AdWoU+iE0s2b2Cbx9QdaPoOL8tqOHOfs0YC 8yLNGlM/ZXFBOU5mhbyytJQfEaxwBvBSC60SUEHia0ez9cf2J0tIQidVQhIA6GE/ +fkx5iefhJKmaSLEcqGYjS9ht9UVud840EjhcpEJKzIPCNobIoBOXFIAlJjoE6SH BkmPAZbRE4ZPZlPgpINcXU5CbemiuNvefNHa4GT8Xm+I4e+3xuXe783X+WBBbk6a 7CVjQpEeTD08217PresnDxWjfRUWhyXkLiYR5fYGfT2+HHTcryRN7ptc1UHBhO9V 97suUHZf+a/Y8r7FT7ubI9nmpUtkNwJk2VXr9avnDWCXU0XN6SmSvAxR8MZe8lp8 8gPsyNNA6+KGFGNK0CI0nAuyWxl4k/0WDCRDyLjpzQoTNwoh+hu9bnLBOkOKloUb WGucejXFd3uDEGhVkDe4e71scqkzanOFfe6/svFqTfap2vlyPoI+wEy+tuy6cugi YEws6v4Dto7mXAlcC1ne9MgOSFf6G7BkxpriAGtGYZTko6gp14Q= =n71x -----END PGP SIGNATURE----- --Xkbk1b7HAn6kxKBY2fb9D7SczkdQfNvPj--