tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: [VOTE] Release Apache Tomcat 6.0.49
Date Fri, 13 Jan 2017 14:13:44 GMT
Am 13.01.2017 um 10:38 schrieb Violeta Georgieva:
> The proposed Apache Tomcat 6.0.49 release is now available for voting.
>
> Note: This is the last Tomcat 6 release.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-6/v6.0.49/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1114/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_49/
>
> The proposed 6.0.49 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 6.0.49 Stable

+1 to release, details and some observations below.

- SHA1 and MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
   - except for some unexpected (?) line ending differences (see below)
- src consistent with svn tag
   - except for .gitignore file
- builds fine
- build result looks consistent with binaries
- JMX MBean comparison with previous version OK
   - no changes in attribute structure
   - scan tldScanTime maybe a bit lower than before
- Some javadoc warnings as normal for TC6
- no errors or failures in the unit tests
   - some observations see below

Build was done using Java 1.5.0_22, OS was Solaris 10 Sparc.

Some observations:

1) Line Endings in Unix bin tarball

I think this started with 6.0.38.

There are files with DOS line endings in the bin tar.gz. If I rebuild 
from scratch on a Unix platform, they have Unix line endings. The source 
tarballs and zips do have their corresponding platform line endings, but 
not the binary ones.

The files with DOS line endings in the bin tarball are:

- jsp, java and html files in webapps/examples

plus:

RELEASE-NOTES
bin/catalina-tasks.xml
webapps/examples/jsp/jsp2/jspx/basic.jspx
webapps/examples/jsp/jsp2/jspx/textRotate.jspx
webapps/examples/jsp/jsp2/misc/coda.jspf
webapps/examples/jsp/jsp2/misc/prelude.jspf
webapps/examples/WEB-INF/classes/LocalStrings_en.properties
webapps/examples/WEB-INF/classes/LocalStrings_es.properties
webapps/examples/WEB-INF/classes/LocalStrings_fr.properties
webapps/examples/WEB-INF/classes/LocalStrings_pt.properties
webapps/examples/WEB-INF/classes/LocalStrings.properties
webapps/examples/WEB-INF/jsp/debug-taglib.tld
webapps/examples/WEB-INF/jsp/example-taglib.tld
webapps/examples/WEB-INF/jsp2/jsp2-example-taglib.tld
webapps/examples/WEB-INF/tags/displayProducts.tag
webapps/examples/WEB-INF/tags/helloWorld.tag
webapps/examples/WEB-INF/tags/panel.tag
webapps/examples/WEB-INF/tags/xhtmlbasic.tag
webapps/examples/WEB-INF/web.xml
webapps/host-manager/images/asf-logo.svg
webapps/host-manager/index.jsp
webapps/host-manager/manager.xml
webapps/host-manager/META-INF/context.xml
webapps/host-manager/WEB-INF/jsp/401.jsp
webapps/host-manager/WEB-INF/jsp/403.jsp
webapps/host-manager/WEB-INF/web.xml
webapps/manager/images/asf-logo.svg
webapps/manager/index.jsp
webapps/manager/META-INF/context.xml
webapps/manager/status.xsd
webapps/manager/WEB-INF/jsp/401.jsp
webapps/manager/WEB-INF/jsp/403.jsp
webapps/manager/WEB-INF/jsp/sessionDetail.jsp
webapps/manager/WEB-INF/jsp/sessionsList.jsp
webapps/manager/WEB-INF/web.xml
webapps/manager/xform.xsl
webapps/ROOT/asf-logo-wide.svg
webapps/ROOT/index.html
webapps/ROOT/index.jsp
webapps/ROOT/RELEASE-NOTES.txt
webapps/ROOT/tomcat.svg
webapps/ROOT/WEB-INF/web.xml

2) Unit test SEVERE and WARN log lines and exceptions
(probably not new)

a) SEVERE: Unable to start election when member was removed.

in org.apache.catalina.tribes.group.interceptors.NonBlockingCoordinator 
memberDisappeared

with either

org.apache.catalina.tribes.ChannelException: Operation has timed 
out(3000 ms.).; Faulty members:tcp://{...}:4001;

or

org.apache.catalina.tribes.ChannelException: java.net.ConnectException: 
Connection refused; Faulty members:tcp://{...}:4008;

always in 
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator

twice for bio and nio, once for apr.

b) WARNING: Error receiving mcast package. Sleeping 500ms

mostly in 
org.apache.catalina.tribes.membership.McastServiceImpl$ReceiverThread run

combined with

java.io.InterruptedIOException: operation interrupted

for the following tests in org.apache.catalina.tribes.group:

- TestGroupChannelMemberArrival
- TestGroupChannelOptionFlag
- TestGroupChannelStartStop
- interceptors.TestDomainFilterInterceptor
- interceptors.TestNonBlockingCoordinator
- interceptors.TestOrderInterceptor
- interceptors.TestTcpFailureDetector

c) WARNING: An application attempted to obtain a request dispatcher with 
an illegal path [/prefix/%2E%2E/target] that was rejected because it 
contained an encoded directory traversal attempt

in org.apache.catalina.core.ApplicationContext getRequestDispatcher

combined with

java.lang.IllegalArgumentException

in test org.apache.catalina.core.TestApplicationContext for bio, nio, apr.

d) java.lang.NoClassDefFoundError: 
org/apache/catalina/tribes/transport/nio/NioReplicationTask$2

once Exception in thread "pool-1-thread-2" and once Exception in thread 
"pool-4-thread-4", both in 
org.apache.catalina.tribes.membership.McastServiceImpl$ReceiverThread 
run for test 
org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor (bio).

Exception stack:

org.apache.catalina.tribes.transport.nio.NioReplicationTask.cancelKey(NioReplicationTask.java:259)
org.apache.catalina.tribes.transport.nio.NioReplicationTask.run(NioReplicationTask.java:106)
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:651)
...

and

org.apache.catalina.tribes.transport.nio.NioReplicationTask.cancelKey(NioReplicationTask.java:259)
org.apache.catalina.tribes.transport.nio.NioReplicationTask.remoteEof(NioReplicationTask.java:217)
org.apache.catalina.tribes.transport.nio.NioReplicationTask.drainChannel(NioReplicationTask.java:166)
org.apache.catalina.tribes.transport.nio.NioReplicationTask.run(NioReplicationTask.java:91)
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:651)
...

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message