tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 60161] RewriteValve: Add more logging support similar to mod-rewrite
Date Thu, 22 Sep 2016 07:21:57 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=60161

--- Comment #6 from Santhana Preethi <santhanapreethi28@gmail.com> ---
(In reply to Mark Thomas from comment #2)

> The switch from the container's logger to a dedicated Rewrite logger is
> problematic too.

I don't think writing all rewrite logs to container's logger is a good idea. In
the current situation, adjusting container's logger level to DEBUG is required
to write rewrite logs. 

(In reply to Christopher Schultz from comment #3)

> Now so? I would think this might be the one good part of this proposed
> patch, because it makes it easier to adjust the log level of *only* the
> RewriteValve. 

As Christopher pointed out, this would make it easier to configure log level
for RewriteValve. 

(In reply to Mark Thomas from comment #2)

> There might be a case for recording the time taken to rewrite the URL but a)
> it should only be collected and logged when debug logging is enabled and b)
> should use nanoTime.

I've reworked the patch with log levels DEBUG,TRACE and nanoTime. I've
replicated httpd mod_rewrite logging behaviour where level 2 logs only the
rewrite information and level 3 also logs all the rules that were applied
before the rewrite happened.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message