tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 59289] Upgrade processor is put in recycledProcessors stack of Http11NioProtocol.Http11ConnectionHandler
Date Fri, 08 Apr 2016 18:18:29 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=59289

--- Comment #2 from Alexander Malyshev <anmalyshev@mail.ru> ---
Does that mean that you have a fix for this issue?
Looking at the code it's not clean if it's enough to just skip recycling such
Upgrade connectors or it's also needed to execute the code similar to the one
executed in normal scenario:

                        UpgradeToken upgradeToken =
processor.getUpgradeToken();
                        HttpUpgradeHandler httpUpgradeHandler =
upgradeToken.getHttpUpgradeHandler();
                        InstanceManager instanceManager =
upgradeToken.getInstanceManager();
                        if (instanceManager == null) {
                            httpUpgradeHandler.destroy();
                        } else {
                            ClassLoader oldCL =
upgradeToken.getContextBind().bind(false, null);
                            try {
                                httpUpgradeHandler.destroy();
                               
instanceManager.destroyInstance(httpUpgradeHandler);
                            } finally {
                                upgradeToken.getContextBind().unbind(false,
oldCL);
                            }
                        }

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message