tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rémy Maucherat <r...@apache.org>
Subject Re: svn commit: r1734592 - /tomcat/trunk/java/javax/el/ImportHandler.java
Date Fri, 11 Mar 2016 17:23:31 GMT
2016-03-11 18:20 GMT+01:00 Konstantin Kolinko <knst.kolinko@gmail.com>:

> 2016-03-11 19:54 GMT+03:00  <markt@apache.org>:
> > Author: markt
> > Date: Fri Mar 11 16:54:04 2016
> > New Revision: 1734592
> >
> > URL: http://svn.apache.org/viewvc?rev=1734592&view=rev
> > Log:
> > Speed up ImportHandler some more.
> >
> > Modified:
> >     tomcat/trunk/java/javax/el/ImportHandler.java
> >
> > Modified: tomcat/trunk/java/javax/el/ImportHandler.java
> > URL:
> http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/ImportHandler.java?rev=1734592&r1=1734591&r2=1734592&view=diff
> >
> ==============================================================================
> > --- tomcat/trunk/java/javax/el/ImportHandler.java (original)
> > +++ tomcat/trunk/java/javax/el/ImportHandler.java Fri Mar 11 16:54:04
> 2016
> > @@ -191,8 +191,23 @@ public class ImportHandler {
> >      private Class<?> findClass(String name, boolean throwException) {
> >          Class<?> clazz;
> >          ClassLoader cl = Thread.currentThread().getContextClassLoader();
> > +        String path = name.replace(".", "/");
>
> You wanted to call replace(char, char) above, but you are using
> (String, String) version using regexps.
>
> The dot regexp matches any character...
>
> Ok, that was a nice one.

Rémy

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message