tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1703866 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/WsFrameBase.java java/org/apache/tomcat/websocket/WsFrameClient.java java/org/apache/tomcat/websocket/WsSession.java webapps/docs/changelog.xml
Date Fri, 18 Sep 2015 14:58:20 GMT
On 18/09/2015 15:51, Yilong Li wrote:
> Are you using the 1.7-SNAPSHOT downloaded recently? It's frequently
> updated. If that's the case, then it's probably a real race and I have to
> take a closer look.

Downloaded at around 10.30 UTC today.

The races looked plausible. There was an obvious ordering because of the
I/O but assuming the completion handlers are using a thread pool (so a
new thread is not created to handle the completion) I could believe that
a field update in the 'main' thread wasn't immediately visible to the
completion handler thread unless the field was volatile.

Mark


> 
> Thanks,
> Yilong
> 
> On Fri, Sep 18, 2015 at 7:43 AM, Mark Thomas <markt@apache.org> wrote:
> 
>> On 18/09/2015 15:27, Yilong Li wrote:
>>> Hi Mark,
>>>
>>> I think these are false positives because the completion handler is only
>>> called after the IO operation completes. There is an implicit
>>> happens-before order here. I have fixed these false positives recently.
>>> That's why I didn't report them in BZ. Could you try the latest version
>> of
>>> RV-Predict instead? Sorry for the inconvenience because RV-Predict is
>> also
>>> in active development based on the feedback we get from testing it
>> against
>>> other projects.
>>
>> I'm using 1.7-SNAPSHOT.
>>
>> Mark
>>
>>
>>>
>>> Thanks,
>>> Yilong
>>>
>>> On Fri, Sep 18, 2015 at 7:14 AM, <markt@apache.org> wrote:
>>>
>>>> Author: markt
>>>> Date: Fri Sep 18 14:14:18 2015
>>>> New Revision: 1703866
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1703866&view=rev
>>>> Log:
>>>> Fix various data races reported by RV-Predict.
>>>> Mostly caused by completion handlers that execute in a new thread
>>>>
>>>> Modified:
>>>>     tomcat/tc8.0.x/trunk/   (props changed)
>>>>
>>  tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java
>>>>
>>>> tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsFrameClient.java
>>>>     tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsSession.java
>>>>     tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
>>>>
>>>> Propchange: tomcat/tc8.0.x/trunk/
>>>>
>>>>
>> ------------------------------------------------------------------------------
>>>> --- svn:mergeinfo (original)
>>>> +++ svn:mergeinfo Fri Sep 18 14:14:18 2015
>>>> @@ -1 +1 @@
>>>>
>>>>
>> -/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886,1644890,1644

>>  8
>> 92
>>>>
>>>>
>> ,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,1655558,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657592,1657607,1657609,1
>>  6
>> 57
>>>>
>>>>
>> 682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1666387,1666494,1666496,1666552,1666569,1666579,166663
>>  7
>> ,1
>>>>
>>>>
>> 666649,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-1684527,1684549-1684550,1685556,1685591,1685739,1685744,1685772,168
>>  5
>> 81
>>>>
>>>>
>> 6,1685826,1685891,1687242,1687261,1687268,1687340,1688563,1688841,1688878,1688885,1688896,1688901,1689345-1689346,1689357,1689656,1689675-1689677,1689679,1689687,1689825,1689856,1689918,1690011,1690021,1690054,1690080,1690209,1691134,1691487,1691813,1692744-1692747,1692849,1693088,1693105,1693429,1693461,1694058,1694111,1694290,1694501,1694548,1694658,1694660,1694788,1694872,1694878,1695006,1695354,1695371,1695459,1695582,1695706,1695778,1696199,1696272,1696280,1696366-1696368,1696378,1696390,1696392,1696467,1700607,1700870,1700896,1700977,1701093,1701123,1701213,1701607,1701666,1701673,1701760-1701761,1701765,1701940,1702183,1702246,1702250,1702268,1702313,1702531,1702630-1702635,1702637-1702638,1702640,1702647,1702660,1702662,1702665-1702666,1702668,1702671-1702673,1702675-1702676,1702680,1702722,1702778,1702795,1702862,1702881,1702886,1702910,1702923,1702971,1702984,1703024,1703040,1703044,1703049-1703050,1703143,1703146,1703151,1703160,1703164,1703167,1703174,1703192,1703287,
>>  1
>> 70
>>>>
>>>>
>> 3290,1703358,1703408,1703486,1703509,1703523,1703542,1703545,1703554,1703584,1703673,1703676,1703678,1703680,1703763,1703784,1703821,1703842,1703849,1703851,1703853,1703856,1703860
>>>>
>>>>
>> +/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886,1644890,1644

>>  8
>> 92
>>>>
>>>>
>> ,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,1655558,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657592,1657607,1657609,1
>>  6
>> 57
>>>>
>>>>
>> 682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1666387,1666494,1666496,1666552,1666569,1666579,166663
>>  7
>> ,1
>>>>
>>>>
>> 666649,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-1684527,1684549-1684550,1685556,1685591,1685739,1685744,1685772,168
>>  5
>> 81
>>>>
>>>>
>> 6,1685826,1685891,1687242,1687261,1687268,1687340,1688563,1688841,1688878,1688885,1688896,1688901,1689345-1689346,1689357,1689656,1689675-1689677,1689679,1689687,1689825,1689856,1689918,1690011,1690021,1690054,1690080,1690209,1691134,1691487,1691813,1692744-1692747,1692849,1693088,1693105,1693429,1693461,1694058,1694111,1694290,1694501,1694548,1694658,1694660,1694788,1694872,1694878,1695006,1695354,1695371,1695459,1695582,1695706,1695778,1696199,1696272,1696280,1696366-1696368,1696378,1696390,1696392,1696467,1700607,1700870,1700896,1700977,1701093,1701123,1701213,1701607,1701666,1701673,1701760-1701761,1701765,1701940,1702183,1702246,1702250,1702268,1702313,1702531,1702630-1702635,1702637-1702638,1702640,1702647,1702660,1702662,1702665-1702666,1702668,1702671-1702673,1702675-1702676,1702680,1702722,1702778,1702795,1702862,1702881,1702886,1702910,1702923,1702971,1702984,1703024,1703040,1703044,1703049-1703050,1703143,1703146,1703151,1703160,1703164,1703167,1703174,1703192,1703287,
>>  1
>> 70
>>>>
>>>>
>> 3290,1703358,1703408,1703486,1703509,1703523,1703542,1703545,1703554,1703584,1703673,1703676,1703678,1703680,1703763,1703784,1703821,1703842,1703849,1703851,1703853,1703856,1703860,1703865
>>>>
>>>> Modified:
>>>> tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java
>>>> URL:
>>>>
>> http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java?rev=1703866&r1=1703865&r2=1703866&view=diff
>>>>
>>>>
>> ==============================================================================
>>>> ---
>> tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java
>>>> (original)
>>>> +++
>> tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java
>>>> Fri Sep 18 14:14:18 2015
>>>> @@ -78,13 +78,13 @@ public abstract class WsFrameBase {
>>>>      private final byte[] mask = new byte[4];
>>>>      private int maskIndex = 0;
>>>>      private long payloadLength = 0;
>>>> -    private long payloadWritten = 0;
>>>> +    private volatile long payloadWritten = 0;
>>>>
>>>>      // Attributes tracking state
>>>> -    private State state = State.NEW_FRAME;
>>>> +    private volatile State state = State.NEW_FRAME;
>>>>      private volatile boolean open = true;
>>>> -    private int readPos = 0;
>>>> -    protected int writePos = 0;
>>>> +    private volatile int readPos = 0;
>>>> +    protected volatile int writePos = 0;
>>>>
>>>>      public WsFrameBase(WsSession wsSession, Transformation
>>>> transformation) {
>>>>          inputBuffer = new byte[Constants.DEFAULT_BUFFER_SIZE];
>>>>
>>>> Modified:
>>>> tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsFrameClient.java
>>>> URL:
>>>>
>> http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsFrameClient.java?rev=1703866&r1=1703865&r2=1703866&view=diff
>>>>
>>>>
>> ==============================================================================
>>>> ---
>>>> tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsFrameClient.java
>>>> (original)
>>>> +++
>>>> tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsFrameClient.java
>>>> Fri Sep 18 14:14:18 2015
>>>> @@ -37,7 +37,7 @@ public class WsFrameClient extends WsFra
>>>>      private final AsyncChannelWrapper channel;
>>>>      private final CompletionHandler<Integer,Void> handler;
>>>>      // Not final as it may need to be re-sized
>>>> -    private ByteBuffer response;
>>>> +    private volatile ByteBuffer response;
>>>>
>>>>      public WsFrameClient(ByteBuffer response, AsyncChannelWrapper
>> channel,
>>>>              WsSession wsSession, Transformation transformation) {
>>>>
>>>> Modified:
>>>> tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsSession.java
>>>> URL:
>>>>
>> http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsSession.java?rev=1703866&r1=1703865&r2=1703866&view=diff
>>>>
>>>>
>> ==============================================================================
>>>> --- tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsSession.java
>>>> (original)
>>>> +++ tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsSession.java
>>>> Fri Sep 18 14:14:18 2015
>>>> @@ -85,10 +85,10 @@ public class WsSession implements Sessio
>>>>      private final String id;
>>>>
>>>>      // Expected to handle message types of <String> only
>>>> -    private MessageHandler textMessageHandler = null;
>>>> +    private volatile MessageHandler textMessageHandler = null;
>>>>      // Expected to handle message types of <ByteBuffer> only
>>>> -    private MessageHandler binaryMessageHandler = null;
>>>> -    private MessageHandler.Whole<PongMessage> pongMessageHandler =
>> null;
>>>> +    private volatile MessageHandler binaryMessageHandler = null;
>>>> +    private volatile MessageHandler.Whole<PongMessage>
>> pongMessageHandler
>>>> = null;
>>>>      private volatile State state = State.OPEN;
>>>>      private final Object stateLock = new Object();
>>>>      private final Map<String,Object> userProperties = new
>>>> ConcurrentHashMap<>();
>>>>
>>>> Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
>>>> URL:
>>>>
>> http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1703866&r1=1703865&r2=1703866&view=diff
>>>>
>>>>
>> ==============================================================================
>>>> --- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original)
>>>> +++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Fri Sep 18 14:14:18
>>>> 2015
>>>> @@ -230,6 +230,10 @@
>>>>          removal could fail for binary and pong MessageHandlers. Patch
>>>> provided
>>>>          by DJ. (markt)
>>>>        </fix>
>>>> +      <fix>
>>>> +        Data races detected by RV-Predict, mostly caused by completion
>>>> handlers
>>>> +        running in separate threads. (markt)
>>>> +      </fix>
>>>>      </changelog>
>>>>    </subsection>
>>>>    <subsection name="Web applications">
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>>
>>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message