tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Schultz <ch...@christopherschultz.net>
Subject Re: porting netty-tcnative to tomcat-native
Date Tue, 16 Jun 2015 19:16:36 GMT
Rémy,

On 6/15/15 5:10 AM, Rémy Maucherat wrote:
> 2015-06-15 10:42 GMT+02:00 Mark Thomas <markt@apache.org>:
> 
>>> It seems they are used in etPeerCertChain() and getCiphers() only, if
>>> someone uses client certificates than might make sense.
>>
>> Those will get called more than once so no objection to caching those
>> classes here.
>>
>> No prooblem with adding that "cahching" but I don't think it will make a
> real performance difference.

Every little bit helps :)

But if it makes the code hard to read, awkward, or otherwise more
difficult to maintain, we should get rid of it.

Right now, it doesn't look too bad.

-chris


Mime
View raw message