tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 57021] Improve logging in AprLifecycleListener and jni.Library when Tomcat-Native DLL fails to load
Date Thu, 12 Feb 2015 12:30:14 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=57021

--- Comment #9 from Christopher Schultz <chris@christopherschultz.net> ---
(In reply to VIN from comment #8)
> Created attachment 32460 [details]
> Updated patch with suggested comments
> 
> Please let me know if anything is missing.

The doc/*.html files should not be in the patch... they are auto-generated from
the xml files elsewhere.

In AprLifecycleListener near line 208, instead of catching Throwable and then
checking for LibraryNotFoundError and UnsatisfiedLinkError, why not add catch
clauses and leave the default action in catch(Throwable)? I think this will be
a better way to do things.

I'm not sure what the implications are, but the old (and default case) code
adds the log message to initInfoLogMessages while the new code performs logging
directly. Is there a reason to prefer one over the other?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message