Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: domain of knst.kolinko@gmail.com
 designates 209.85.192.41 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <20141121190145.C64F12388993@eris.apache.org>
References: <20141121190145.C64F12388993@eris.apache.org>
Date: Fri, 21 Nov 2014 23:59:47 +0300
Message-ID: 
 <CABzHfV=BCOi5dkA5hvZr314YE+nO8kFvkpV4D+stV_78oeuqsw@mail.gmail.com>
Subject: Re: svn commit: r1640978 -
 /tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java
From: Konstantin Kolinko <knst.kolinko@gmail.com>
To: Tomcat Developers List <dev@tomcat.apache.org>
Content-Type: text/plain; charset=UTF-8

2014-11-21 22:01 GMT+03:00  <schultz@apache.org>:
> Author: schultz
> Date: Fri Nov 21 19:01:45 2014
> New Revision: 1640978
>
> URL: http://svn.apache.org/r1640978
> Log:
> Fix Coverty issue 45276: close Jar resource after use.
>
> Modified:
>     tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java
>
> Modified: tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java?rev=1640978&r1=1640977&r2=1640978&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java (original)
> +++ tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java Fri Nov 21 19:01:45 2014
> @@ -124,12 +124,9 @@ class TagLibraryInfoImpl extends TagLibr
>              tldResourcePath = generateTldResourcePath(uri, ctxt);
>          }
>
> -        Jar jar;
> +        Jar jar = null;
>          try {
>              jar = tldResourcePath.getJar();

Good catch.

The "getJar()" method creates a Jar (with JarFactory.newInstance(..)),
but it is a bit unexpected from a getter method.


> -        } catch (IOException ioe) {
> -            throw new JasperException(ioe);
> -        }
>
>          // Add the dependencies on the TLD to the referencing page
>          PageInfo pageInfo = ctxt.createCompiler().getPageInfo();
> @@ -218,6 +215,14 @@ class TagLibraryInfoImpl extends TagLibr
>          this.tags = tagInfos.toArray(new TagInfo[tagInfos.size()]);
>          this.tagFiles = tagFileInfos.toArray(new TagFileInfo[tagFileInfos.size()]);
>          this.functions = functionInfos.toArray(new FunctionInfo[functionInfos.size()]);
> +        } catch (IOException ioe) {
> +            throw new JasperException(ioe);
> +        }
> +        finally
> +        {

Your code formatting is odd. It would better be " } finally { ".

> +            if(null != jar)
> +                jar.close(); // Jar.close does not throw IOException, but probably should
> +        }
>      }


Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org