tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkoli...@apache.org
Subject svn commit: r1624583 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: AnnotationDefault.java Attribute.java
Date Fri, 12 Sep 2014 16:16:15 GMT
Author: kkolinko
Date: Fri Sep 12 16:16:15 2014
New Revision: 1624583

URL: http://svn.apache.org/r1624583
Log:
Drop AnnotationDefault attribute as unused.

Evidences:
1) Its constructor just swallowed an ElementValue without keeping it.
As such, this class has no getter methods and thus provides no value.

2) AnnotationDefault attribute is used to declare default value for an element (aka method)
of an annotation.
As Tomcat is not interested in Annotation declarations, this attribute is of no interest.
Essentially, it scans for known annotations on classes. It is not interested in arbitrary
other annotations.

Cobertura coverage report also showed no calls into AnnotationDefault class.

Removed:
    tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AnnotationDefault.java
Modified:
    tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Attribute.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Attribute.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Attribute.java?rev=1624583&r1=1624582&r2=1624583&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Attribute.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Attribute.java Fri Sep 12 16:16:15
2014
@@ -80,8 +80,6 @@ public abstract class Attribute {
             return new RuntimeVisibleAnnotations(file, constant_pool);
         case Constants.ATTR_RUNTIME_VISIBLE_PARAMETER_ANNOTATIONS:
             return new RuntimeVisibleParameterAnnotations(file, constant_pool);
-        case Constants.ATTR_ANNOTATION_DEFAULT:
-            return new AnnotationDefault(file, constant_pool);
         default: // All other attributes are skipped
             Utility.skipFully(file, length);
             return null;



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message