tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 56588] New: ApplicationListener#pluggabilityBlocked field is always "false" in Tomcat 8
Date Wed, 04 Jun 2014 12:46:07 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=56588

            Bug ID: 56588
           Summary: ApplicationListener#pluggabilityBlocked field is
                    always "false" in Tomcat 8
           Product: Tomcat 8
           Version: 8.0.8
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: knst.kolinko@gmail.com

(Noted when reviewing bug 55282 and its fix - r1597855 )

Apart from ~42 references in text code, the
o.a.t.util.descriptor.web.ApplicationListener constructor is called in only one
place and in that place [1] the pluggabilityBlocked argument is always "false".

[1] org.apache.catalina.startup.ContextConfig#configureContext(WebXml)


Originally this feature was added in r1492307 and this the second constructor
argument was named "fromTLD". The feature is that listeners added by TLD
scanning do not have access to all configuration APIs.

In Tomcat 8 Jasper now initializes itself via JasperInitializer.onStartup() and
adds TLD listeners via ServletContext.addListener(String) calls.

Thus:
1. I suspect that the feature implemented by r1492307 may be currently broken
which means that listeners defined in TLDs have access to full API.

2. ApplicationListener.pluggabilityBlocked field and a bunch of code can be
removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message