tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 56582] New: Use switch(enum) in implementations of ActionHook.action(ActionCode, ...)
Date Sun, 01 Jun 2014 23:59:27 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=56582

            Bug ID: 56582
           Summary: Use switch(enum) in implementations of
                    ActionHook.action(ActionCode, ...)
           Product: Tomcat 8
           Version: 8.0.8
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Connectors
          Assignee: dev@tomcat.apache.org
          Reporter: knst.kolinko@gmail.com

As of now,
AbstractHttp11Processor.action(ActionCode, Object)
AbstractAjpProcessor.action(ActionCode, Object)

are implemented as a chain of if/elseif going through every defined ActionCode.

As ActionCode is an enum starting with Tomcat 7, I think it would be better to
reorganize the code to use switch(enum) construct.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message