tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 56582] Use switch(enum) in implementations of ActionHook.action(ActionCode, ...)
Date Tue, 03 Jun 2014 00:22:32 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=56582

--- Comment #1 from Konstantin Kolinko <knst.kolinko@gmail.com> ---
Done for Tomcat 8 (r1599385 r1599393 r1599395), will be in 8.0.9.

I plan to backport this change to Tomcat 7, as I think switch() behaves better
for performance.

One possible error spotted thanks to IDE warning:
DISPATCH_EXECUTE action code is not processed by AbstractAjpProcessor.
I placed a FIXME comment there.

The fix is likely to copy the code from AbstractHttp11Processor.action():
        case DISPATCH_EXECUTE: {
            getEndpoint().executeNonBlockingDispatches(socketWrapper);
            break;
        }

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message