tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rémy Maucherat <r...@apache.org>
Subject Re: svn commit: r1605724 - in /tomcat/trunk: java/org/apache/catalina/storeconfig/IStoreConfig.java java/org/apache/catalina/storeconfig/LocalStrings.properties java/org/apache/catalina/storeconfig/StoreConfig.java webapps/docs/changelog.xml
Date Thu, 26 Jun 2014 13:30:47 GMT
2014-06-26 14:48 GMT+02:00 Konstantin Kolinko <knst.kolinko@gmail.com>:

> 2. Behaviour of StoreConfig.store(Context aContext)  in case if
> Context.getConfigFile() is null
>
> In general that is a possible configuration (there was no xml file
> when Context started).  Does it need a "log.error()"?
>
> My question does not make sense if in this case the call to store()
> method is skipped somewhere at a higher level.   If the call is
> normally skipped then the error() logging here is justified.
>

I didn't make any change there and it is unused as well. I am not
interested in arguing for hours about details, so I'll leave everything as
is :)

Rémy

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message