tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1601590 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AbstractEndpoint.java AprEndpoint.java JIoEndpoint.java Nio2Endpoint.java
Date Tue, 10 Jun 2014 20:47:13 GMT
On 10/06/2014 21:01, Konstantin Kolinko wrote:
> 2014-06-10 18:06 GMT+04:00 Mark Thomas <markt@apache.org>:
>> On 10/06/2014 10:52, markt@apache.org wrote:
>>> Author: markt
>>> Date: Tue Jun 10 09:52:56 2014
>>> New Revision: 1601590
>>>
>>> URL: http://svn.apache.org/r1601590
>>> Log:
>>> Pull up AsyncTimeout
>>> APR/native used a separate flag to stop the thread. This avoided issues where
running was set true->false-true in quick succession. This fix is now available to NIO2
and BIO as well.
>>> Note NIO does not (currently) use the AsyncTimeout
>>
>> The Async unit test is currently taking 15 mins per test. I'm guessing
>> that I broke something in the async timeouts with this refactoring. I'm
>> looking now.
> 
> http://svn.apache.org/r1601443
> is suspicious for me.
> Was there a reason to add "if (socket.isAsync())" around timeout processing?

Agreed. That was where I looked first too. I added it as APR had it when
I was aligning the code prior to the refactoring. On further review, I
opted to remove it.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message