tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r1598483 - in /tomcat/trunk/webapps: docs/changelog.xml examples/WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java examples/WEB-INF/classes/websocket/echo/EchoStreamAnnotation.java examples/WEB-INF/classes/websocket/echo/servers.json
Date Fri, 30 May 2014 22:47:12 GMT
2014-05-30 11:52 GMT+04:00  <remm@apache.org>:
> Author: remm
> Date: Fri May 30 07:52:52 2014
> New Revision: 1598483
>
> URL: http://svn.apache.org/r1598483
> Log:
> - Test autobahn myself, add two new echo endpoints and my example config.
> - Issues with the async endpoint, 9.7 and 9.8.
>
> Added:
>     tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java
>     tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoStreamAnnotation.java
>     tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/servers.json
> Modified:
>     tomcat/trunk/webapps/docs/changelog.xml
>

I fixed svn:eol-style and other issues in r1598763

What I do not like here is that it is not clear how to use these classes.
They are not referenced in public examples html pages,
not used in unit tests, have no javadoc,

Maybe add Javadoc to them?

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message