Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (athena.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
Sender: Jeremy Boynes <jeremy@boynes.com>
From: Jeremy Boynes <jboynes@apache.org>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_F12309F3-F4AA-4403-85DE-4841219C8778";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Message-Id: <F1295EF5-4ABD-4452-A588-42C0AFBC4BFB@apache.org>
Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\))
Subject: TldScanner + Config, was: Jasper Improvements
Date: Wed, 26 Feb 2014 22:17:40 -0800
References: 
 <CAFmzfTXPkF9eCuNvVWDXC56=XsMK5Q2Z6fpq5t5CdWEV7nvXJw@mail.gmail.com>
 <CAH_y2NFjephhP4iDKGiZkcB0Vau_MKDsCLUwpwyG63A_zDd4uA@mail.gmail.com>
 <CAH_y2NFqLQc7hzHKPATsD_n8Wb2Fg28m--fvuJZKYDofxt14JA@mail.gmail.com>
To: Tomcat Developers List <dev@tomcat.apache.org>
In-Reply-To: 
 <CAH_y2NFqLQc7hzHKPATsD_n8Wb2Fg28m--fvuJZKYDofxt14JA@mail.gmail.com>

--Apple-Mail=_F12309F3-F4AA-4403-85DE-4841219C8778
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=windows-1252

On Feb 26, 2014, at 4:55 PM, Greg Wilkins <gregw@intalio.com> wrote:

> Just in case it was missed, here is the pull request I generated:
>=20
> https://github.com/apache/tomcat/pull/4
>=20
> Happy to talk about individual changes either in the comments there or =
here.

Related to the TldScanner changes, I=92m assuming you have some =
integration code in Jetty that is sub-classing the initializer and =
overriding newTldScanner?

I was thinking of supporting compile-on-start as a option where the =
initializer would scan the war for JSP(x) files and initiate the =
compilation during startup. This was intended for production use where =
use of JspC was not practical (e.g. because the actual version of =
runtime is not known at pre-compilation time) but where taking a hit on =
access would be undesirable. I was thinking there to combine the TLD and =
JSP scans into one.

There may be other reasons to scan e.g. looking for tag-plugins packaged =
in jars (no XML config needed a bit like a Tld).

We also have an issue where Jasper is very reliant on system properties =
and the Options built from the init-params of JspServlet.

In short, I=92m wondering if instead of the subclassing we define a =
JasperConfiguration interface and have the initializer look for an =
instance of it in a context attribute. The configuration there would =
allow the container to replace parts of Jasper=92s initialization (e.g. =
by supplying a Collection<URL> of pre-scanned TLDs, by identifying TLDs =
"provided by the container=94 etc.) and other configuration on a =
per-context basis.

Would something like that work for you?
Cheers
Jeremy


--Apple-Mail=_F12309F3-F4AA-4403-85DE-4841219C8778
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQEcBAEBCgAGBQJTDtiEAAoJEKVK0I6noCM8GegH/R+zslCNHE429d9tMHrkBSgU
3y4KHf/1IND7oXK+jeGF/5WYekS2BNEnykee4JpDzA3pRYG0sRkwdIHCqLWeU8b5
pvRauUxz3UTVzGaeo7QsdPiaSaoeXkV/vaKzL019YDgOSZ7N89vnuO+y6/pwi+fs
NiVLZqzu2ujaWMEymYCLDaTTthOeY+4oBVz4WUj7uMWg45S4tl5kdRiQCsrULD6x
OvKc2c4sCueDsqFl3px02q00TBO8pjrEf/jlDN8A+XBaXICYbIIfdk2BEYp0Ltca
HJ/neWMSHz+WHGPELU9IEbuk42rar8e7M00X2iViO4e6U6ecmG9phllrdVDpuRM=
=duPG
-----END PGP SIGNATURE-----

--Apple-Mail=_F12309F3-F4AA-4403-85DE-4841219C8778--