Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: domain of knst.kolinko@gmail.com
 designates 209.85.212.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <20140220090453.3C277238899C@eris.apache.org>
References: <20140220090453.3C277238899C@eris.apache.org>
Date: Thu, 20 Feb 2014 13:10:06 +0400
Message-ID: 
 <CABzHfV=mh1stsjAMLtMGaaf0HcaWqfwZh2zqK1siGc9s_=A4qg@mail.gmail.com>
Subject: Re: svn commit: r1570115 - in /tomcat/tc7.0.x/trunk: ./ build.xml
 webapps/docs/changelog.xml
From: Konstantin Kolinko <knst.kolinko@gmail.com>
To: Tomcat Developers List <dev@tomcat.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

2014-02-20 13:04 GMT+04:00  <markt@apache.org>:
> Author: markt
> Date: Thu Feb 20 09:04:52 2014
> New Revision: 1570115
>
> URL: http://svn.apache.org/r1570115
> Log:
> Simplify patternsets where possible
> Avoid pattern sets ending in "/*" as much as possible as they usually result in JARs containing empty packages with the contents of the package in a different JAR
>
> Modified:
>     tomcat/tc7.0.x/trunk/   (props changed)
>     tomcat/tc7.0.x/trunk/build.xml
>     tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
>
> Propchange: tomcat/tc7.0.x/trunk/
> ------------------------------------------------------------------------------
>   Merged /tomcat/trunk:r1570114
>
> Modified: tomcat/tc7.0.x/trunk/build.xml
> URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/build.xml?rev=1570115&r1=1570114&r2=1570115&view=diff
> ==============================================================================
> --- tomcat/tc7.0.x/trunk/build.xml (original)
> +++ tomcat/tc7.0.x/trunk/build.xml Thu Feb 20 09:04:52 2014
> @@ -277,20 +277,18 @@
>    <!-- ========= Pattern sets used to control content of JAR files ========= -->
>    <!-- Pattern sets for jar files in standard distributions -->
>    <patternset id="files.annotations-api">
> -    <include name="javax/annotation/*" />
> -    <include name="javax/annotation/security/*" />
> -    <include name="javax/annotation/sql/*" />
> -    <include name="javax/ejb/*" />
> -    <include name="javax/persistence/*" />
> -    <include name="javax/xml/ws/*" />
> +    <include name="javax/annotation/**" />
> +    <include name="javax/ejb/**" />
> +    <include name="javax/persistence/**" />
> +    <include name="javax/xml/ws/**" />
>    </patternset>
>
>    <patternset id="files.servlet-api">
> -    <include name="javax/servlet/*" />
> -    <include name="javax/servlet/annotation/*" />
> -    <include name="javax/servlet/descriptor/*" />
> -    <include name="javax/servlet/http/*" />
> -    <include name="javax/servlet/resources/*" />
> +    <include name="javax/servlet/*.class" />

I do not like these *.class patterns.

I think occasionally having an empty package is less evil than missing
a *.properties file.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org