Return-Path: X-Original-To: apmail-tomcat-dev-archive@www.apache.org Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9A57B10B65 for ; Wed, 8 Jan 2014 10:59:38 +0000 (UTC) Received: (qmail 9096 invoked by uid 500); 8 Jan 2014 10:59:27 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 9022 invoked by uid 500); 8 Jan 2014 10:59:20 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 9009 invoked by uid 99); 8 Jan 2014 10:59:16 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Jan 2014 10:59:16 +0000 Received: from localhost (HELO mail-oa0-f51.google.com) (127.0.0.1) (smtp-auth username remm, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Jan 2014 10:59:16 +0000 Received: by mail-oa0-f51.google.com with SMTP id m1so1599182oag.10 for ; Wed, 08 Jan 2014 02:59:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=xYBxP3k5coix5IxyNcCW4yFIyKClEb5FtWUAktddbxA=; b=HcMCfj+bTNDthSrFRGp+iyrh380FfH0LFPO5fb+75cYKpNS4s0AGGFS02lKPJgohCz FxKiYRfZIkfKz7cXRTpodTx8ADGgnW6OWGsRCEFw4vVCinzZRZwb0GHWTdIvW6oBm7gT U+YaoBYWack9nBPUjoshqOArFbuHf0H7CF97e4SIXI9svIgT2imhLSDXyDB4xk5eGsEI EnSCuo0OZbOeXnriyNJ++Yl7EJQA3O67+mnxPbBWV4MmqUvhthnKoWFv9tDz4vHISH4m H3Ci7HtpxeSh5TyvoOIZ1HxSdOo583/Qy81dkAFgzl25Ai/XqJKNK0hnIPwjHfF3h7YR oKDA== MIME-Version: 1.0 X-Received: by 10.60.99.8 with SMTP id em8mr55589543oeb.8.1389178755453; Wed, 08 Jan 2014 02:59:15 -0800 (PST) Received: by 10.76.69.100 with HTTP; Wed, 8 Jan 2014 02:59:15 -0800 (PST) In-Reply-To: <52CD28AC.9040308@apache.org> References: <20140106234032.F1318238890D@eris.apache.org> <52CD28AC.9040308@apache.org> Date: Wed, 8 Jan 2014 11:59:15 +0100 Message-ID: Subject: Re: svn commit: r1556071 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java From: =?ISO-8859-1?Q?R=E9my_Maucherat?= To: Tomcat Developers List Content-Type: multipart/alternative; boundary=047d7b33cad23f9ce104ef736264 --047d7b33cad23f9ce104ef736264 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable 2014/1/8 Mark Thomas > Tomcat only does this if the WriteListener is set via the > CoyoteOutputStream. It does not do it if HTTP upgrade is used (which > uses a lighter-weight ServletOutputStream). That looks like a bug that > needs fixing. > > Yes, I saw after my commit there was code to do it for HTTP, but upgrade uses the code in the AbstractServletOutputStream which only sets the listener and doesn't do anything with it until there's an actual write. R=E9my --047d7b33cad23f9ce104ef736264--